Fwxv 999 warrenxu 103 hw #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarvisWeng
reviewed
Jan 2, 2024
projects/queues/src/main.c
Outdated
| } | ||
| TASK(task2, TASK_STACK_512) { | ||
| LOG_DEBUG("Task 2 initialized!\n"); | ||
| const char outstr[ITEM_SZ]; |
There was a problem hiding this comment.
You should initialize your array like so
const char outstr[ITEM_SZ] = {};
projects/queues/src/main.c
Outdated
| uint32_t receive = 0; | ||
| while (true) { | ||
| // Your code goes here | ||
| ret = queue_receive(&s_queue1, &receive, 1000); |
There was a problem hiding this comment.
This &receive, doesn't really make sense. You're trying to put the item you receive in receive, but the receive size is only 4 bytes, while the item size is 6 bytes
JarvisWeng
reviewed
Jan 3, 2024
projects/queues/src/main.c
Outdated
| uint32_t to_send = 0; | ||
| while (true) { | ||
| // Your code goes here | ||
| ret = queue_send(&s_queue1, s_list[to_send], 0); |
There was a problem hiding this comment.
You want to use &s_list[to_send] because this function takes in the address of the value you want to send, not the value itself
JarvisWeng
reviewed
Jan 3, 2024
projects/queues/src/main.c
Outdated
| LOG_DEBUG("write to queue failed\n"); | ||
| } | ||
| delay_ms(100); | ||
| ++to_send; |
There was a problem hiding this comment.
What about when to_send is greater than 5? What happens then?
JarvisWeng
reviewed
Jan 5, 2024
projects/queues/src/main.c
Outdated
| delay_ms(100); | ||
| ++to_send; | ||
| if (to_send >= 5) { | ||
| ret = STATUS_CODE_OUT_OF_RANGE; |
There was a problem hiding this comment.
You should just use % QUEUE_LEN. That'll just go back to the first item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fw 102 tasks