-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix stty panic on glibc 2.42 (hotfix) #9483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2c9b0e6 to
118d1f4
Compare
|
i think you committed way too many files |
|
@ChrisDryden Is this not conflicting with any your PRs? |
|
GNU testsuite comparison: |
118d1f4 to
d15d4a1
Compare
|
😴 |
|
i |
|
GNU testsuite comparison: |
|
I patched your PR to main at Arch Linux. But |
|
This project has |
This doesn't appear to conflict with any of the open PR's should be good to go. |
|
i should contribute to nix instead fix the underlying API so |
|
#9483 (comment) Thankyou. |
|
#9483 (comment) nix rust-libc people are hesitating to use both of raw ioctl and versioned symbol of glibc BTW... |
|
GNU testsuite comparison: |
|
@naoNao89 nix-rust/nix#2672 (comment) with help of |
|
@oech3 Sorry for being AFK for a few days, i have been busy with some heists. See you in the next 16 hours :)) |
|
is it ready ? |
|
Waiting merge of rust-lang/libc#4882 instead |
sylvestre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to be rebased
Catches panics from
cfgetospeed()on glibc 2.42. Removes.expect()and.unwrap()calls in termios handling. Suppresses panic messages.stty now gracefully skips speed display instead of crashing.
Temporary workaround pending upstream nix fix.
Fixes #8474