tr: Raise error if set2 is too big on complemented class #6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenjiSann
force-pushed
the
renji/tr-fix-set2-too-big
branch
from
5ad3321
to
80390e9
Compare
BenWiederhake
requested changes
Jul 14, 2024
There was a problem hiding this comment.
The code change itself is great! It's really straight-forward, thanks to the previous PRs.
I have some requests about the test: Please test the positive case, fix a technically-incorrect comment, and make sure the test checks for the correct failure reason. (Details below.)
RenjiSann
force-pushed
the
renji/tr-fix-set2-too-big
branch
2 times, most recently
from
d73616f
to
b6955ee
Compare
RenjiSann
force-pushed
the
renji/tr-fix-set2-too-big
branch
from
b6955ee
to
a26bd3b
Compare
|
Force push fixed this:
|
This was referenced Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6345