Skip to content

stat: warn once when QUOTING_STYLE env has an unknown value#12136

Merged
cakebaker merged 2 commits intouutils:mainfrom
sylvestre:fix/stat-quoting-style-env-warning
May 6, 2026
Merged

stat: warn once when QUOTING_STYLE env has an unknown value#12136
cakebaker merged 2 commits intouutils:mainfrom
sylvestre:fix/stat-quoting-style-env-warning

Conversation

@sylvestre
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

GNU testsuite comparison:

GNU test failed: tests/cp/sparse-to-pipe. tests/cp/sparse-to-pipe is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/stat/stat-fmt is no longer failing!
Skip an intermittent issue tests/cut/bounded-memory (was skipped on 'main', now failing)

@collinfunk
Copy link
Copy Markdown

The test case added in this pull request is a verbatim copy of the test that I added to tests/stat/stat-fmt.sh, which is under GPLv3+.

@sylvestre
Copy link
Copy Markdown
Contributor Author

sorry, let me rewrite it

@sylvestre sylvestre force-pushed the fix/stat-quoting-style-env-warning branch from 4677f47 to 2a62720 Compare May 4, 2026 06:33
@sylvestre sylvestre marked this pull request as ready for review May 4, 2026 09:37
Comment on lines +469 to +470
res.stdout_is("nom=['baguette']\nnom=['Croissant']\nnom=['Escargot']\n");
assert_eq!(res.stderr_str().matches(needle).count(), 1);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would check stdout and stderr in the same way you do below.

@sylvestre sylvestre force-pushed the fix/stat-quoting-style-env-warning branch from 9eb962f to 9a0a20d Compare May 5, 2026 18:42
@cakebaker
Copy link
Copy Markdown
Contributor

It looks like you added some unrelated commits.

@sylvestre sylvestre force-pushed the fix/stat-quoting-style-env-warning branch from 9a0a20d to 74e580c Compare May 6, 2026 07:39
@cakebaker cakebaker merged commit 20f7af8 into uutils:main May 6, 2026
171 of 172 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Congrats! The gnu test tests/stat/stat-fmt is no longer failing!

Great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants