Open
Conversation
Contributor
|
Is this dynamically linked againsyt libsystemd.so? If so, this should be disabled by default. |
Contributor
Author
Change to fallback only |
|
GNU testsuite comparison: |
- Gate all feat_systemd_logind #[cfg] attributes with target_os = "linux" so that non-Linux builds are unaffected by the libsystemd link requirement - Fall back to traditional getutxent() when SystemdUtmpxIter::new() fails at runtime, instead of returning an empty iterator
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat_systemd_logind#[cfg]attributes withtarget_os = "linux"so that non-Linux builds (macOS, FreeBSD, etc.) are unaffected by thelibsystemdlink requirementgetutxent()whenSystemdUtmpxIter::new()fails at runtime, instead of returning an empty iteratorContext
On Ubuntu 26.04,
usersprints nothing while GNUuserscorrectly shows logged-in users. Modern systemd no longer populates/var/run/utmp, so utilities that rely on it produce no output. Thefeat_systemd_logindfeature was opt-in, meaning default builds never queried systemd-logind.