dd: improve allocation strategy for huge bs#11577
Open
oech3 wants to merge 1 commit intouutils:mainfrom
Open
Conversation
Merging this PR will improve performance by ×7.5
Performance Changes
Comparing Footnotes
|
749b867 to
eb5c742
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
xtqqczze
reviewed
Apr 1, 2026
6cba7fd to
b2e307c
Compare
|
GNU testsuite comparison: |
Contributor
|
We need |
xtqqczze
reviewed
Apr 1, 2026
| // std cannot fix https://github.com/uutils/coreutils/issues/11544 without unsafe yet | ||
| // SAFETY: write-only to reserved area of buf and becomes unaccessible at self.read(slice)? soon | ||
| let slice = unsafe { | ||
| std::slice::from_raw_parts_mut(chunk.as_mut_ptr().cast::<u8>(), chunk.len()) |
Contributor
There was a problem hiding this comment.
This unsafe code is the equivalent of chunk.assume_init_mut(), which causes undefined behavior when the content is not fully initialized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #11544