Skip to content

tail: add WASI support by disabling notify and pid features#11569

Merged
sylvestre merged 1 commit intouutils:mainfrom
sylvestre:wasm-pr3
Apr 3, 2026
Merged

tail: add WASI support by disabling notify and pid features#11569
sylvestre merged 1 commit intouutils:mainfrom
sylvestre:wasm-pr3

Conversation

@sylvestre
Copy link
Copy Markdown
Contributor

WASI has no file watching (inotify/kqueue) or process management APIs. Disable notify and libc on WASI, provide Observer stubs so tail compiles, and add fallback values for BACKEND and polling_help. The follow mode (-f) returns an error on WASI since it cannot work without a file watching backend.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

WASI has no file watching (inotify/kqueue) or process management APIs.
Disable notify and libc on WASI, provide Observer stubs so tail
compiles, and add fallback values for BACKEND and polling_help.
The follow mode (-f) returns an error on WASI since it cannot work
without a file watching backend.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 1, 2026

Merging this PR will not alter performance

✅ 303 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing sylvestre:wasm-pr3 (71ea599) with main (1e81775)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

GNU testsuite comparison:

GNU test failed: tests/tail/pid-pipe. tests/tail/pid-pipe is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!

@sylvestre sylvestre marked this pull request as ready for review April 1, 2026 20:20
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/retry is no longer failing!

@cakebaker
Copy link
Copy Markdown
Contributor

cakebaker commented Apr 2, 2026

There are many "never constructed" and "never used" warnings: https://github.com/uutils/coreutils/actions/runs/23864636617/job/69581278691?pr=11569#step:18:296

Update: I fixed the warnings unrelated to tail in #11599

@sylvestre sylvestre merged commit ab37e41 into uutils:main Apr 3, 2026
169 of 170 checks passed
kevinburkesegment pushed a commit to kevinburkesegment/coreutils that referenced this pull request Apr 6, 2026
…1569)

WASI has no file watching (inotify/kqueue) or process management APIs.
Disable notify and libc on WASI, provide Observer stubs so tail
compiles, and add fallback values for BACKEND and polling_help.
The follow mode (-f) returns an error on WASI since it cannot work
without a file watching backend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants