Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
|
GNU testsuite comparison: |
This comment was marked as resolved.
This comment was marked as resolved.
|
macOS's rustix does not have raw backend helping binary size. Also we need to remove nix from uucore since |
|
Also it is known that raw backend is sometimes bad perf compared with nix. So we might switch to use-libc backend and revert binary size. Even so, we reduce 1 dep needed to build. |
| #[cfg(any(target_os = "linux", target_os = "android"))] | ||
| #[error("{0}")] | ||
| Nix(#[from] nix::Error), | ||
| Rustix(#[from] rustix::io::Errno), |
There was a problem hiding this comment.
I don't know. But clippy did not say anything about unused import.
There was a problem hiding this comment.
Clippy doesn't warn about unused enum variants.
|
is there a difference in Linux binary size, I'm just interested...? |
This comment was marked as outdated.
This comment was marked as outdated.
|
I did |
|
Did you strip binaries? |
No, these are the stripped sizes:
|
So rustix (especially raw) may be a good size improvement. |
depends on #11566split #11548