coreutils: Protect against env -a for security by oech3 · Pull Request #10773 · uutils/coreutils

oech3 · 2026-02-06T18:18:53Z

env -a false ls does not fail. Works under masked /proc.
Closes #10135

github-actions · 2026-02-06T18:53:12Z

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.

github-actions · 2026-02-07T08:03:06Z

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

codspeed-hq · 2026-02-07T17:34:51Z

Merging this PR will not alter performance

✅ 298 untouched benchmarks
⏩ 48 skipped benchmarks¹

_{Comparing oech3:auxval (2d60946) with main (d202b45)}

48 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-02-08T16:59:29Z

GNU testsuite comparison:

GNU test failed: tests/cut/bounded-memory. tests/cut/bounded-memory is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/pr/bounded-memory is no longer failing!

ChrisDryden · 2026-02-08T20:50:51Z

I think it would make sense for this code to go into the validation.rs file instead of in the main.rs, then you don't have to worry about importing libc.

It would be good to have an additional integration test that shows the env -a working

github-actions · 2026-02-08T22:13:02Z

GNU testsuite comparison:

Congrats! The gnu test tests/tail/tail-n0f is now passing!

github-actions · 2026-02-09T08:49:03Z

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/tail/tail-n0f is now passing!

github-actions · 2026-02-09T12:36:54Z

GNU testsuite comparison:

Congrats! The gnu test tests/tail/tail-n0f is now passing!

github-actions · 2026-02-09T16:13:04Z

GNU testsuite comparison:

GNU test failed: tests/cut/bounded-memory. tests/cut/bounded-memory is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/pr/bounded-memory. tests/pr/bounded-memory is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/tail/tail-n0f is now passing!

github-actions · 2026-02-11T12:14:23Z

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)

github-actions · 2026-03-12T03:02:41Z

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/cp/copy-FMR is now being skipped but was previously passing.
Note: The gnu test tests/shuf/shuf-reservoir is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-stale-thread-mem is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-u-FMR is now being skipped but was previously passing.
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

github-actions · 2026-03-12T03:13:28Z

GNU testsuite comparison:

GNU test failed: tests/cp/parent-perm-race. tests/cp/parent-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/cp/copy-FMR is now being skipped but was previously passing.
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Note: The gnu test tests/shuf/shuf-reservoir is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-stale-thread-mem is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-u-FMR is now being skipped but was previously passing.
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

github-actions · 2026-03-12T06:48:32Z

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/cp/copy-FMR is now being skipped but was previously passing.
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Note: The gnu test tests/shuf/shuf-reservoir is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-stale-thread-mem is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-u-FMR is now being skipped but was previously passing.
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Congrats! The gnu test tests/pr/bounded-memory is now passing!

oech3 · 2026-03-12T06:57:11Z

I was considering calling true under the symlink chain:
invalid-name -> coreutils -> true for better symlink support.
Does it cover some usecase for shebang call?

oech3 · 2026-03-12T13:29:16Z

Is read()ing #! faster than reading /proc/self/exe?

oech3 · 2026-03-12T14:28:09Z

I did too many conversion for file pathes. Please drop them by review...

github-actions · 2026-03-12T14:38:45Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/cp/copy-FMR is now being skipped but was previously passing.
Note: The gnu test tests/shuf/shuf-reservoir is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-stale-thread-mem is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-u-FMR is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/pipe-f is now passing!

github-actions · 2026-03-12T17:19:50Z

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cp/copy-FMR is now being skipped but was previously passing.
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Note: The gnu test tests/shuf/shuf-reservoir is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-stale-thread-mem is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-u-FMR is now being skipped but was previously passing.
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

github-actions · 2026-03-13T06:11:07Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cp/copy-FMR is now being skipped but was previously passing.
Note: The gnu test tests/shuf/shuf-reservoir is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-stale-thread-mem is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-u-FMR is now being skipped but was previously passing.
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

Co-authored-by: Etienne Cordonnier <ecordonnier@snap.com>

github-actions · 2026-03-14T13:02:37Z

GNU testsuite comparison:

Note: The gnu test tests/cp/copy-FMR is now being skipped but was previously passing.
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Note: The gnu test tests/shuf/shuf-reservoir is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-stale-thread-mem is now being skipped but was previously passing.
Note: The gnu test tests/sort/sort-u-FMR is now being skipped but was previously passing.

oech3 · 2026-03-21T10:46:29Z

is this ok?

oech3 · 2026-03-26T07:05:26Z

@Ecordonnier ok?

sylvestre · 2026-03-26T07:32:45Z

Cargo.toml

 rust-ini = "0.21.0"
+# binary name of coreutils can be hijacked by overriding getauxval via LD_PRELOAD
+# So we use param and avoid libc backend
+rustix = { version = "1.1.4", features = ["param"] }


same comment about rustix ?
why not libc or nix?

In this case, nix or libc's getauxval can be hijacked by LD_PRELOAD. Directly scanning stack prevends it.

#10773 (comment)

seems overkill to add rustix for this for now

Why? Multi-call binary is called many times. We should bypass overhead of linker if possible. Also this is already part of dependency tree.

i would prefer we extract the code/method from rustix to do it here

Extracting AT_EXECFN is low-level operation. We would achieve unsafe and magic constant.

oech3 marked this pull request as ready for review February 6, 2026 19:18

oech3 force-pushed the auxval branch 3 times, most recently from 01b6655 to 753f86c Compare February 7, 2026 07:47

oech3 force-pushed the auxval branch from 753f86c to 94ee016 Compare February 7, 2026 16:20

oech3 force-pushed the auxval branch 2 times, most recently from 59e307c to ac75ff7 Compare February 8, 2026 15:58

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

oech3 force-pushed the auxval branch 3 times, most recently from 1337cbc to 40581ee Compare February 8, 2026 21:47

oech3 force-pushed the auxval branch 2 times, most recently from a5dd042 to 526f6fc Compare February 9, 2026 08:32

oech3 force-pushed the auxval branch from 526f6fc to 9d6a743 Compare February 9, 2026 12:27

oech3 force-pushed the auxval branch from 9d6a743 to 3f57dd7 Compare February 9, 2026 16:04

oech3 mentioned this pull request Feb 9, 2026

test_env: Make argv0 tests compatible with Ubuntu patch #10834

Merged

oech3 marked this pull request as draft February 9, 2026 16:40

oech3 mentioned this pull request Feb 15, 2026

coreutils: Resolve symlink with invalid binary name for better dummy support #10946

Open

This comment was marked as outdated.

Sign in to view

oech3 force-pushed the auxval branch from 7f8d719 to 7da47ec Compare March 12, 2026 03:06

This comment was marked as outdated.

Sign in to view

oech3 force-pushed the auxval branch 2 times, most recently from b9cb65f to 5a57da3 Compare March 12, 2026 06:40

This comment was marked as outdated.

Sign in to view

oech3 marked this pull request as draft March 12, 2026 09:50

oech3 force-pushed the auxval branch 2 times, most recently from a2fec5c to 880c4ba Compare March 12, 2026 14:23

oech3 marked this pull request as ready for review March 12, 2026 14:50

oech3 force-pushed the auxval branch 2 times, most recently from 0c8b3c6 to 3b4ab62 Compare March 12, 2026 17:11

oech3 force-pushed the auxval branch from 3b4ab62 to 029284d Compare March 13, 2026 05:58

coreutils: Protect against env -a for security

2d60946

Co-authored-by: Etienne Cordonnier <ecordonnier@snap.com>

oech3 force-pushed the auxval branch 2 times, most recently from c54b52f to 2d60946 Compare March 14, 2026 12:52

oech3 requested a review from Ecordonnier March 14, 2026 13:20

sylvestre reviewed Mar 26, 2026

View reviewed changes

Uh oh!

Conversation

oech3 commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 7, 2026

Uh oh!

codspeed-hq bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

github-actions bot commented Feb 8, 2026

Uh oh!

ChrisDryden commented Feb 8, 2026

Uh oh!

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as resolved.

github-actions bot commented Feb 8, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

This comment was marked as outdated.

github-actions bot commented Mar 12, 2026

Uh oh!

This comment was marked as outdated.

github-actions bot commented Mar 12, 2026

Uh oh!

oech3 commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

oech3 commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oech3 commented Mar 12, 2026

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 14, 2026

Uh oh!

oech3 commented Mar 21, 2026

Uh oh!

oech3 commented Mar 26, 2026

Uh oh!

sylvestre Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 Mar 26, 2026

Choose a reason for hiding this comment

oech3 commented Feb 6, 2026 •

edited

Loading

codspeed-hq bot commented Feb 7, 2026 •

edited

Loading

oech3 commented Mar 12, 2026 •

edited

Loading

oech3 commented Mar 12, 2026 •

edited

Loading