numfmt: add grouping and debug options with locale support #10506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `--grouping` option to use locale-specific separators in output - Add `--debug` option to print warnings during processing - Add `libc` dependency for locale handling - Update help and error messages for new options - Add validation to prevent combining grouping with format - Include translations for new options in en-US and fr-FR locales
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging this PR will degrade performance by 65.65%Comparing Summary
Performance Changes
Footnotes
|
- Conditionally compile locale-related functions for non-Windows platforms - Add Windows-specific stub implementations for `init_locale`, `locale_decimal_separator_char`, and `locale_grouping_separator_string` - Mark test helper functions with `#[cfg(test)]` to avoid unused code warnings - Simplify error handling using `let Some` and `let Ok` patterns - Replace unsafe C string literal with safer `c""` macro
…rging - Extracted `format_field_parse_error` function to centralize error message formatting - Improved `merge_ranges` function with more efficient algorithm using iterator pattern - Fixed logic bug where grouping validation was checking wrong condition - Added early return for empty ranges in merge_ranges for better performance - Simplified error handling in parse_field_list by using the new helper function
|
GNU testsuite comparison: |
Contributor
|
Once again, please split your pr into several small PR ... |
mattsu2020
changed the title
This commit introduces comprehensive support for handling large numbers and decimal precision in the numfmt utility. Key changes include: - Added num-bigint and num-traits dependencies for arbitrary precision arithmetic - Implemented DecimalValue struct for precise decimal number representation - Added new error messages for value overflow scenarios
|
GNU testsuite comparison: |
…pplied Added checks for `from_unit` and `to_unit` being 1 to ensure `use_raw` is correctly set when no unit conversion or formatting is applied, fixing potential formatting issues in numfmt.
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--groupingoption to use locale-specific separators in output--debugoption to print warnings during processinglibcdependency for locale handlingrelated
tests/numfmt/numfmt.pl