Skip to content

Conversation

@ChrisDryden
Copy link
Collaborator

@ChrisDryden ChrisDryden commented Jan 7, 2026

The GNU numfmt utility has a debug flag that has a few integration tests in numfmt. It has debug messages for three things, when grouping is used in a locale that has no effect, no conversion option specified and "header ignored with command line input"

The grouping functionality is not yet implemented so I could only start with the debug messaging for the conversion option specified and the ignored with command line input debug message.

This makes 2 more tests out of the 72 remaining numfmt related tests pass.

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 16.32%

Comparing ChrisDryden:numfmt-debug-flag (60ef234) with main (425b232)

Summary

⚡ 8 improved benchmarks
❌ 2 regressed benchmarks
✅ 272 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory dd_copy_partial 127.7 KB 132 KB -3.25%
Memory du_wide_tree[(5000, 500)] 1.2 MB 1.2 MB +3.01%
Memory cp_large_file[16] 115.4 KB 109.8 KB +5.1%
Memory sort_numeric[500000] 48.7 MB 46 MB +5.8%
Memory sort_long_line[160000] 716.7 KB 856.4 KB -16.32%
Memory sort_mixed_data[500000] 25.8 MB 22.4 MB +15.2%
Memory sort_unique_locale[500000] 36.9 MB 33 MB +11.83%
Memory sort_ascii_only[500000] 25.5 MB 21.9 MB +16.76%
Memory sort_accented_data[500000] 25.5 MB 21.6 MB +18.11%
Memory sort_key_field[500000] 32.8 MB 29.2 MB +12.53%

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ChrisDryden ChrisDryden marked this pull request as ready for review January 7, 2026 20:45
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.

@sylvestre
Copy link
Contributor

some jobs are failing, could you please have a look? thanks
(maybe a merge problem)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants