You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think there's no need for a oneof structure to achieve the goal of having a flexible query mechanism for blocks.
In proto3, all message fields are considered optional. This means that the BlockRef struct already provides a way for the user to select which combination of fields to send. You can, for example, already send something like BlockRef { index: 2000 } (without any other value) and it will be accepted by the interface.
If we move to a oneof approach, we're in constraining rather than relaxing the options of the user (because it wouldn't have a way of specifying both values).
I would modify the PR to:
discard the AnyBlockIdentifier since we don't need it
add a new height field to the BlockRef struct to support it as a query criteria
rename index -> slot to improve readability
explain via docs how to interpret the BlockRef structure as a query input that supports any combination of field
Once merged, the more concrete problem is to make sure that backend providers (like Dingo, Dolos, etc) follow the correct semantics when processing these requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #148