netsync, main: always download headers for blocks #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specified a peer Both of the functions currently default to the syncPeer for fetching blocks and utreexo headers but if we allow our peers to send over headers instead of invs, then we may not have a syncPeer as we're no longer in ibd. To allow these functions to be re-used when our peer sends us block headers, we allow the caller to pass in the desired peer to request the additional data from.
On VerAck, we send MsgSendHeaders to notify the peer that we prefer headers instead of invs for blocks.
Since we'll always use the individual requestedUtreexoHeaders per peer, we never need to have a global map. The global map is only useful during inv requests but since we'll be syncing off of headers instead, we don't need to have this map at all.
We'll only be syncing off of headers so we can re-use the fetchHeaderBlocks even when we're not in headers first mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change the code to handle headers and request headers from peers for
new block messages. This allows utreexo nodes to use the same code for
syncing up during ibd for new blocks as well.