wire, main, indexers: remove unconfirmed marker #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unconfirmed marker created a discrepancy between the proof sent out for blocks and transactions. It was used for marking if a referenced tx that was being spent was unconfirmed or not but it's removed in favor of the node checking locally for the referenced tx. If the node is unable to find all the referenced txs, the tx is put into the orphan pool.
kcalvinalvin
force-pushed
the
2024-06-19-no-unconfirmed-marker
branch
from
6d5d407
to
24f29d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unconfirmed marker created a discrepancy between the proof sent out
for blocks and transactions. It was used for marking if a referenced tx
that was being spent was unconfirmed or not but it's removed in favor of
the node checking locally for the referenced tx. If the node is unable
to find all the referenced txs, the tx is put into the orphan pool.