blockchain, utreexobackends: move nodesmapslice and cachedleavesmapslice to utreexobackends #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving nodesMapSlice to a separate package ensures that private fields don't get accessed and the code is safer for concurrency due to this. This addresses a bug that was noticed that resulted in a runtime panic due to concurrent access of a map in nodesMapSlice.
Moving cached leaves map to a separate package ensures that private fields do not get accessed. This achieves better concurrency guarantees as the exported functions of cached leaves map are concurrency safe but if the fields get accessed directly, it bypasses the safety measures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving these two to a separate package allows us to better control access to private fields. There was a runtime panic due to an unexported field being accessed, leading to a concurrent map read and write. Moving it into a separate package avoids this issue completely.