Skip to content

Commit

Permalink
Change pull_request_target to pull_request in CI (#89)
Browse files Browse the repository at this point in the history
* Change pull_request_target to pull_request in CI

* Add fmod version as parameter to get_fmod.py script

* Add note in readme for adding secrets on fork repo to PR.

* Update fmod test banks
  • Loading branch information
piiertho authored Oct 30, 2021
1 parent c701073 commit de2397d
Show file tree
Hide file tree
Showing 19 changed files with 85 additions and 71 deletions.
22 changes: 15 additions & 7 deletions .github/workflows/all_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
branches: [ master ]
tags:
- "v*"
pull_request_target:
pull_request:
branches: "*"

# Global Settings
Expand All @@ -13,6 +13,7 @@ env:
TARGET: release
GODOT_VERSION: 3.3.4
UTOPIA_GODOT_CPP_REF: utopia-3.3.4-stable
FMOD_VERSION: 20203

jobs:
windows-compilation:
Expand All @@ -25,6 +26,7 @@ jobs:
uses: actions/checkout@v2
with:
submodules: recursive
lfs: true

# Use python 3.x release (works cross platform; best to keep self contained in it's own step)
- name: Set up Python 3.x
Expand All @@ -48,7 +50,7 @@ jobs:
cd ..
New-Item -ItemType directory -Path libs; cd libs
New-Item -ItemType directory -Path fmod; cd fmod
python ../../${{env.PROJECT_FOLDER}}/get_fmod.py ${{secrets.FMODUSER}} ${{secrets.FMODPASS}} windows
python ../../${{env.PROJECT_FOLDER}}/get_fmod.py ${{secrets.FMODUSER}} ${{secrets.FMODPASS}} windows ${{env.FMOD_VERSION}}
7z x ${{env.FMOD_EXECUTABLE}}
mv api/ windows
cd ../../
Expand Down Expand Up @@ -88,6 +90,7 @@ jobs:
uses: actions/checkout@v2
with:
submodules: recursive
lfs: true

# Install all packages (except scons)
- name: Configure dependencies
Expand Down Expand Up @@ -118,7 +121,7 @@ jobs:
cd ..
mkdir libs && cd libs
mkdir fmod && cd fmod
python ../../${{env.PROJECT_FOLDER}}/get_fmod.py ${{secrets.FMODUSER}} ${{secrets.FMODPASS}} linux
python ../../${{env.PROJECT_FOLDER}}/get_fmod.py ${{secrets.FMODUSER}} ${{secrets.FMODPASS}} linux ${{env.FMOD_VERSION}}
tar -xvf ${{env.FMOD_EXECUTABLE}}
mv fmodstudioapi20203linux/api linux
cd ../../
Expand Down Expand Up @@ -158,6 +161,7 @@ jobs:
uses: actions/checkout@v2
with:
submodules: recursive
lfs: true

# Use python 3.x release (works cross platform; best to keep self contained in it's own step)
- name: Set up Python 3.x
Expand All @@ -181,7 +185,7 @@ jobs:
cd ..
mkdir libs && cd libs
mkdir fmod && cd fmod
python ../../${{env.PROJECT_FOLDER}}/get_fmod.py ${{secrets.FMODUSER}} ${{secrets.FMODPASS}} osx
python ../../${{env.PROJECT_FOLDER}}/get_fmod.py ${{secrets.FMODUSER}} ${{secrets.FMODPASS}} osx ${{env.FMOD_VERSION}}
hdiutil attach ${{env.FMOD_EXECUTABLE}}
cp -r "/Volumes/FMOD Programmers API Mac/FMOD Programmers API/api" osx
cd ../../
Expand Down Expand Up @@ -221,6 +225,7 @@ jobs:
uses: actions/checkout@v2
with:
submodules: recursive
lfs: true

- name: Set up Java 8
uses: actions/setup-java@v1
Expand Down Expand Up @@ -248,7 +253,7 @@ jobs:
cd ..
mkdir libs && cd libs
mkdir fmod && cd fmod
python ../../${{env.PROJECT_FOLDER}}/get_fmod.py ${{secrets.FMODUSER}} ${{secrets.FMODPASS}} android
python ../../${{env.PROJECT_FOLDER}}/get_fmod.py ${{secrets.FMODUSER}} ${{secrets.FMODPASS}} android ${{env.FMOD_VERSION}}
tar -xvf ${{env.FMOD_EXECUTABLE}}
mv fmodstudioapi20203android/api android
cd ../../
Expand Down Expand Up @@ -293,6 +298,7 @@ jobs:
uses: actions/checkout@v2
with:
submodules: recursive
lfs: true

# Use python 3.x release (works cross platform)
- name: Set up Python 3.x
Expand All @@ -316,7 +322,7 @@ jobs:
cd ..
mkdir libs && cd libs
mkdir fmod && cd fmod
python ../../${{env.PROJECT_FOLDER}}/get_fmod.py ${{secrets.FMODUSER}} ${{secrets.FMODPASS}} ios
python ../../${{env.PROJECT_FOLDER}}/get_fmod.py ${{secrets.FMODUSER}} ${{secrets.FMODPASS}} ios ${{env.FMOD_VERSION}}
hdiutil attach ${{env.FMOD_EXECUTABLE}}
cp -r "/Volumes/FMOD Programmers API iOS/FMOD Programmers API/api" ios
cd ../../
Expand Down Expand Up @@ -362,6 +368,7 @@ jobs:
uses: actions/checkout@v2
with:
submodules: recursive
lfs: true

# Use python 3.x release (works cross platform; best to keep self contained in it's own step)
- name: Set up Python 3.x
Expand All @@ -385,7 +392,7 @@ jobs:
cd ..
mkdir libs && cd libs
mkdir fmod && cd fmod
python ../../${{env.PROJECT_FOLDER}}/get_fmod.py ${{secrets.FMODUSER}} ${{secrets.FMODPASS}} osx
python ../../${{env.PROJECT_FOLDER}}/get_fmod.py ${{secrets.FMODUSER}} ${{secrets.FMODPASS}} osx ${{env.FMOD_VERSION}}
hdiutil attach ${{env.FMOD_EXECUTABLE}}
cp -r "/Volumes/FMOD Programmers API Mac/FMOD Programmers API/api" osx
cd ../../
Expand Down Expand Up @@ -435,6 +442,7 @@ jobs:
uses: actions/checkout@v2
with:
submodules: recursive
lfs: true

- name: Download Artefacts
uses: actions/download-artifact@v2
Expand Down
25 changes: 15 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,8 @@ func _ready():
Fmod.init(1024, Fmod.FMOD_STUDIO_INIT_LIVEUPDATE, Fmod.FMOD_INIT_NORMAL)
# load banks
Fmod.load_bank("res://Master Bank.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master Bank.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Music.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# register listener
Expand All @@ -278,8 +278,8 @@ func _ready():
Fmod.set_sound_3D_settings(1.0, 64.0, 1.0)
# load banks
Fmod.load_bank("res://Master Bank.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master Bank.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Music.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# register listener
Expand Down Expand Up @@ -350,8 +350,8 @@ func _ready():
Fmod.set_sound_3D_settings(1.0, 64.0, 1.0)
# load banks
Fmod.load_bank("res://Master Bank.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master Bank.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Music.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# register listener
Expand Down Expand Up @@ -442,8 +442,8 @@ func _ready():
Fmod.setSound3DSettings(1.0, 64.0, 1.0)
# load banks
Fmod.load_bank("res://Master Bank.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master Bank.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Music.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# register listener
Expand Down Expand Up @@ -479,8 +479,8 @@ func _ready():
Fmod.setSound3DSettings(1/0, 64.0, 1.0)
# load banks
Fmod.load_bank("res://Master Bank.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master Bank.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Master.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://Music.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# register listener
Expand Down Expand Up @@ -536,6 +536,11 @@ print(perf_data.memory)
print(perf_data.file)
```

## Contributing

In order to be able to PR this repo from a fork, you need to add `FMODUSER` and `FMODPASS` secrets to your fork repo.
This enables CI to download FMOD api.

## Thanks

This project is a forked from [godot-fmod-integration](https://github.com/alexfonseka/godot-fmod-integration)
Expand Down
4 changes: 2 additions & 2 deletions demo/Script/FmodTest.gd
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ func _enter_tree():

# load banks
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Music.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Expand Down
Binary file removed demo/assets/Banks/Master Bank.bank
Binary file not shown.
Binary file removed demo/assets/Banks/Master Bank.strings.bank
Binary file not shown.
Binary file added demo/assets/Banks/Master.bank
Binary file not shown.
Binary file added demo/assets/Banks/Master.strings.bank
Binary file not shown.
Binary file modified demo/assets/Banks/Music.bank
Binary file not shown.
Binary file modified demo/assets/Banks/SFX.bank
Binary file not shown.
Binary file modified demo/assets/Banks/Vehicles.bank
Binary file not shown.
16 changes: 8 additions & 8 deletions demo/test/unit/test_bank.gd
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ class TestBank:
func before_all():
# load banks
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Music.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Expand All @@ -23,8 +23,8 @@ class TestBank:

func after_all():
Fmod.remove_listener(0)
Fmod.unload_bank("res://assets/Banks/Master Bank.strings.bank")
Fmod.unload_bank("res://assets/Banks/Master Bank.bank")
Fmod.unload_bank("res://assets/Banks/Master.strings.bank")
Fmod.unload_bank("res://assets/Banks/Master.bank")
Fmod.unload_bank("res://assets/Banks/Music.bank")
Fmod.unload_bank("res://assets/Banks/Vehicles.bank")
assert_eq(Fmod.get_bank_loading_state("res://assets/Banks/Vehicles.bank"), -1, "Loading state should be -1")
Expand All @@ -33,28 +33,28 @@ class TestBank:
var desiredValue: int = 0
assert_eq(Fmod.get_bank_bus_count("res://assets/Banks/Music.bank"), desiredValue, "Music bank should have " + str(desiredValue) + " buses")
desiredValue = 12
assert_eq(Fmod.get_bank_bus_count("res://assets/Banks/Master Bank.bank"), desiredValue, "Master bank should have " + str(desiredValue) + " buses")
assert_eq(Fmod.get_bank_bus_count("res://assets/Banks/Master.bank"), desiredValue, "Master bank should have " + str(desiredValue) + " buses")
desiredValue = 0
assert_eq(Fmod.get_bank_bus_count("res://assets/Banks/Vehicles.bank"), desiredValue, "Vehicles bank should have " + str(desiredValue) + " buses")

func test_assert_bank_event_count():
var desiredValue: int = 4
assert_eq(Fmod.get_bank_event_count("res://assets/Banks/Music.bank"), desiredValue, "Music bank should have " + str(desiredValue) + " events")
desiredValue = 5
assert_eq(Fmod.get_bank_event_count("res://assets/Banks/Master Bank.bank"), desiredValue, "Master bank should have " + str(desiredValue) + " events")
assert_eq(Fmod.get_bank_event_count("res://assets/Banks/Master.bank"), desiredValue, "Master bank should have " + str(desiredValue) + " events")
desiredValue = 2
assert_eq(Fmod.get_bank_event_count("res://assets/Banks/Vehicles.bank"), desiredValue, "Vehicles bank should have " + str(desiredValue) + " events")

func test_assert_bank_string_count():
var desiredValue: int = 0
assert_eq(Fmod.get_bank_string_count("res://assets/Banks/Music.bank"), desiredValue, "Music bank should have " + str(desiredValue) + " strings")
assert_eq(Fmod.get_bank_string_count("res://assets/Banks/Master Bank.bank"), desiredValue, "Master bank should have " + str(desiredValue) + " strings")
assert_eq(Fmod.get_bank_string_count("res://assets/Banks/Master.bank"), desiredValue, "Master bank should have " + str(desiredValue) + " strings")
assert_eq(Fmod.get_bank_string_count("res://assets/Banks/Vehicles.bank"), desiredValue, "Vehicles bank should have " + str(desiredValue) + " strings")

func test_assert_bank_vca_count():
var desiredValue: int = 0
assert_eq(Fmod.get_bank_VCA_count("res://assets/Banks/Music.bank"), desiredValue, "Music bank should have " + str(desiredValue) + " VCAs")
desiredValue = 3
assert_eq(Fmod.get_bank_VCA_count("res://assets/Banks/Master Bank.bank"), desiredValue, "Master bank should have " + str(desiredValue) + " VCAs")
assert_eq(Fmod.get_bank_VCA_count("res://assets/Banks/Master.bank"), desiredValue, "Master bank should have " + str(desiredValue) + " VCAs")
desiredValue = 0
assert_eq(Fmod.get_bank_VCA_count("res://assets/Banks/Vehicles.bank"), desiredValue, "Vehicles bank should have " + str(desiredValue) + " VCAs")
8 changes: 4 additions & 4 deletions demo/test/unit/test_bus.gd
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ class TestBus:
func before_all():
# load banks
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Music.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Expand All @@ -24,8 +24,8 @@ class TestBus:
func after_all():
Fmod.release_event(id)
Fmod.remove_listener(0)
Fmod.unload_bank("res://assets/Banks/Master Bank.strings.bank")
Fmod.unload_bank("res://assets/Banks/Master Bank.bank")
Fmod.unload_bank("res://assets/Banks/Master.strings.bank")
Fmod.unload_bank("res://assets/Banks/Master.bank")
Fmod.unload_bank("res://assets/Banks/Music.bank")
Fmod.unload_bank("res://assets/Banks/Vehicles.bank")

Expand Down
8 changes: 4 additions & 4 deletions demo/test/unit/test_callbacks.gd
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ class TestCallbacks:
func before_all():
# load banks
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Music.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Expand All @@ -21,8 +21,8 @@ class TestCallbacks:

func after_all():
Fmod.remove_listener(0)
Fmod.unload_bank("res://assets/Banks/Master Bank.strings.bank")
Fmod.unload_bank("res://assets/Banks/Master Bank.bank")
Fmod.unload_bank("res://assets/Banks/Master.strings.bank")
Fmod.unload_bank("res://assets/Banks/Master.bank")
Fmod.unload_bank("res://assets/Banks/Music.bank")
Fmod.unload_bank("res://assets/Banks/Vehicles.bank")

Expand Down
20 changes: 10 additions & 10 deletions demo/test/unit/test_desc_event.gd
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ class TestEventDescription:
func before_all():
# load banks
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Music.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Expand All @@ -24,8 +24,8 @@ class TestEventDescription:
func after_all():
Fmod.release_event(id)
Fmod.remove_listener(0)
Fmod.unload_bank("res://assets/Banks/Master Bank.strings.bank")
Fmod.unload_bank("res://assets/Banks/Master Bank.bank")
Fmod.unload_bank("res://assets/Banks/Master.strings.bank")
Fmod.unload_bank("res://assets/Banks/Master.bank")
Fmod.unload_bank("res://assets/Banks/Music.bank")
Fmod.unload_bank("res://assets/Banks/Vehicles.bank")

Expand Down Expand Up @@ -63,12 +63,12 @@ class TestEventDescription:
func test_assert_should_not_have_cue():
assert_false(Fmod.desc_has_sustain_point("event:/Vehicles/Car Engine"), "Event description should not have cue")

func test_assert_min_max_distance():
var desiredMin: float = 1.0
var desiredMax: float = 20.0
var minMaxDistance = Fmod.desc_get_min_max_distance("event:/Vehicles/Car Engine")
assert_eq(minMaxDistance[0], desiredMin, "Event description minimum distance should be " + str(desiredMin))
assert_eq(minMaxDistance[1], desiredMax, "Event description maximum distance should be " + str(desiredMax))
func test_assert_min_max_distance():
var desiredMin: float = 1.0
var desiredMax: float = 20.0
var minMaxDistance = Fmod.desc_get_min_max_distance("event:/Vehicles/Car Engine")
assert_eq(minMaxDistance[0], desiredMin, "Event description minimum distance should be " + str(desiredMin))
assert_eq(minMaxDistance[1], desiredMax, "Event description maximum distance should be " + str(desiredMax))

func test_assert_sound_size():
var desiredValue: float = 2.0
Expand Down
8 changes: 4 additions & 4 deletions demo/test/unit/test_event.gd
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ class TestEvent:
func before_all():
# load banks
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Music.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Expand All @@ -27,8 +27,8 @@ class TestEvent:
Fmod.stop_event(id, Fmod.FMOD_STUDIO_STOP_IMMEDIATE)
Fmod.release_event(id)
Fmod.remove_listener(0)
Fmod.unload_bank("res://assets/Banks/Master Bank.strings.bank")
Fmod.unload_bank("res://assets/Banks/Master Bank.bank")
Fmod.unload_bank("res://assets/Banks/Master.strings.bank")
Fmod.unload_bank("res://assets/Banks/Master.bank")
Fmod.unload_bank("res://assets/Banks/Music.bank")
Fmod.unload_bank("res://assets/Banks/Vehicles.bank")

Expand Down
8 changes: 4 additions & 4 deletions demo/test/unit/test_global.gd
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ class TestGlobal:
func before_all():
# load banks
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.strings.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Master Bank.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
Fmod.load_bank("res://assets/Banks/Master.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Fmod.load_bank("res://assets/Banks/Music.bank", Fmod.FMOD_STUDIO_LOAD_BANK_NORMAL)
# warning-ignore:return_value_discarded
Expand All @@ -21,8 +21,8 @@ class TestGlobal:

func after_all():
Fmod.remove_listener(0)
Fmod.unload_bank("res://assets/Banks/Master Bank.strings.bank")
Fmod.unload_bank("res://assets/Banks/Master Bank.bank")
Fmod.unload_bank("res://assets/Banks/Master.strings.bank")
Fmod.unload_bank("res://assets/Banks/Master.bank")
Fmod.unload_bank("res://assets/Banks/Music.bank")
Fmod.unload_bank("res://assets/Banks/Vehicles.bank")

Expand Down
Loading

0 comments on commit de2397d

Please sign in to comment.