Throw exception if error code >=400

utopia-php · Oct 17, 2023 · c293d06 · c293d06
1 parent abe1414
commit c293d06
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/VCS/Adapter/Git/GitHub.php b/src/VCS/Adapter/Git/GitHub.php
@@ -198,11 +198,12 @@ public function deleteRepository(string $owner, string $repositoryName): bool
 
         $response = $this->call(self::METHOD_DELETE, $url, ['Authorization' => "Bearer $this->accessToken"]);
 
-        if ($response['headers']['status-code'] == 204) {
-            return true;
-        } else {
-            throw new RepositoryNotFound("Repository not found");
+        $statusCode = $response['headers']['status-code'];
+
+        if ($statusCode >= 400) {
+            throw new Exception("Deleting repository $repositoryName failed with status code $statusCode");
         }
+        return true;
     }
 
     /**

diff --git a/tests/VCS/Base.php b/tests/VCS/Base.php
@@ -2,10 +2,10 @@
 
 namespace Utopia\Tests;
 
+use Exception;
 use PHPUnit\Framework\TestCase;
 use Utopia\App;
 use Utopia\VCS\Adapter\Git;
-use Utopia\VCS\Exception\RepositoryNotFound;
 
 abstract class Base extends TestCase
 {
@@ -97,7 +97,7 @@ public function testDeleteRepository(): void
     {
         $result = $this->vcsAdapter->deleteRepository('test-kh', 'new-repo');
         $this->assertEquals(true, $result);
-        $this->expectException(RepositoryNotFound::class);
+        $this->expectException(Exception::class);
         $result = $this->vcsAdapter->deleteRepository('test-kh', 'new-repo-2');
     }
 }