Skip to content

feat: amqp swoole #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: amqp swoole #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "library",
"keywords": ["php","framework", "upf", "utopia", "tasks", "queue"],
"license": "MIT",
"minimum-stability": "stable",
"minimum-stability": "dev",
"authors": [
{
"name": "Torsten Dittmann",
Expand All @@ -23,9 +23,15 @@
"format": "vendor/bin/pint",
"lint": "vendor/bin/pint --test"
},
"repositories": [
{
"type": "vcs",
"url": "[email protected]:appwrite-labs/php-amqplib.git"
}
],
"require": {
"php": ">=8.3",
"php-amqplib/php-amqplib": "^3.7",
"appwrite-labs/php-amqplib": "master-dev",
"utopia-php/cli": "0.15.*",
Comment on lines 32 to 35
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Unpinned “master-dev” constraint is brittle

"appwrite-labs/php-amqplib": "master-dev" points to a moving target. Any force-push on that branch can silently break downstream builds.

Pin to a tag or specific commit and optionally allow caret/tilde ranges for controlled updates:

-        "appwrite-labs/php-amqplib": "master-dev",
+        "appwrite-labs/php-amqplib": "1.0.0",        // or an exact commit hash

Follow-up: If no stable tag exists yet, consider adding "minimum-stability": "dev" with an explicit "prefer-stable": true to keep Composer satisfied.

🏁 Script executed:

#!/bin/bash
# Locate the php-amqplib entry and surrounding context
grep -R '"appwrite-labs/php-amqplib"' -n composer.json -A3 -B2

# Check for existing stability settings
grep -R '"minimum-stability"' -n composer.json
grep -R '"prefer-stable"' -n composer.json

Length of output: 424

Pin unstable dependency instead of tracking master-dev

Your composer.json is pulling a moving target for the AMQP library:

  • Location: composer.json (line 34)
  • Current requirement: 
    "appwrite-labs/php-amqplib": "master-dev",

This can lead to silent breakages whenever that branch is force-pushed. Pin to a released version or exact commit:

- "appwrite-labs/php-amqplib": "master-dev",
+ "appwrite-labs/php-amqplib": "1.0.0",  // or "dev-master as 1.0.0" / specific commit hash

You already have

"minimum-stability": "stable"

so the -dev suffix on your requirement will still install the branch. No change to stability settings is required unless you intend to broadly allow dev-level packages—in which case add:

"minimum-stability": "dev",
"prefer-stable": true
🤖 Prompt for AI Agents 
In composer.json around lines 32 to 35, the dependency
"appwrite-labs/php-amqplib" is set to "master-dev", which is a moving target and
can cause silent breakages. Replace "master-dev" with a specific released
version tag or an exact commit hash to pin the dependency. Since
"minimum-stability" is already set to "stable", no changes are needed there
unless you want to allow dev packages more broadly, in which case add
"minimum-stability": "dev" and "prefer-stable": true.

"utopia-php/framework": "0.33.*",
"utopia-php/telemetry": "0.1.*",
Expand Down
Loading
Loading