Fix Firebase Phone User Migrations #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohanidamodar
approved these changes
Jul 10, 2024
abnegate
reviewed
Jul 10, 2024
bin/MigrationCLI.php
Outdated
Comment on lines
17
to
25
| protected Appwrite $source; | ||
| protected $source; | ||
|
|
||
| protected DestinationsAppwrite $destination; | ||
| protected $destination; |
There was a problem hiding this comment.
Can we use mixed here if the type is dynamic?
There was a problem hiding this comment.
yep, just changed it
abnegate
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes phone migrations for firebase and other providers by never explicitly assuming a passwordHash exists
Related:
passwordSaltparam" when migrating users from Firebase appwrite/appwrite#8376