Fix: preserve numeric segments in path matching #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update array_filter to use a lambda function that filters out only empty strings. - Ensures numeric segments like '0' are not removed from the path. - Add test to ensure numeric segments are preserved in path matching
TorstenDittmann
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where numeric segments in the path, such as 0, were being filtered out due to the default behavior of array_filter.
Before Change: The segment 0 would be filtered out, potentially causing a 404 error or incorrect route matching.
After Change: The segment 0 is preserved, ensuring the correct route is matched.
The following changes have been made:
Updated the array_filter call to use a lambda function that filters out only empty strings, ensuring numeric segments like
0are preserved.Added a test case to verify that 0 is correctly matched in the path.