GH-611: Accountant Overlapping Scans (self review) #4

utkarshg6 · 2022-10-03T08:51:09Z

No description provided.

…ide tools.rs

…e scan is already running

…dy running

…can is running

…running

…h an empty vector

…ountant/mod.rs

…shed() of scanners.rs

…Scanners

…tops the scan

…uencies

… to process

…until_it_gets_confirmed_or_canceled()

…t/test_utils.rs

…ntant/mod.rs

.idea/inspectionProfiles/Project_Default.xml

masq_lib/src/logger.rs

node/src/accountant/mod.rs

node/src/lib.rs

node/src/sub_lib/accountant.rs

utkarshg6 · 2022-10-03T09:47:06Z

node/src/sub_lib/combined_parameters.rs

@@ -449,7 +449,7 @@ mod tests {
            panic_3_msg,
            &format!(
                "should be called only on uninitialized object, not: ScanIntervals(Some({:?}))",
-                *DEFAULT_SCAN_INTERVALS
+                make_scan_intervals_with_defaults()


Don't use this function, instead just dereference the DEFAULT_SCAN_INTERVALS.

utkarshg6 · 2022-10-03T09:47:51Z

node/src/test_utils/mod.rs

-            when_pending_too_long_sec: DEFAULT_PENDING_TOO_LONG_SEC,
-            suppress_initial_scans: false,
-        }
+    pub fn make_bc_with_defaults() -> BootstrapperConfig {


Try using builder method for building the bootstrap config.

utkarshg6 · 2022-10-03T09:49:02Z

node/src/test_utils/recorder.rs

@@ -112,6 +112,7 @@ recorder_message_handler!(AddReturnRouteMessage);
 recorder_message_handler!(AddRouteMessage);
 recorder_message_handler!(AddStreamMsg);
 recorder_message_handler!(BindMessage);
+recorder_message_handler!(ConnectionProgressMessage);


Move this line after recorder_message_handler!(ScanForPayables);

utkarshg6 added 30 commits July 6, 2022 08:12

GH-611: add test to scan for payables in case flag is false

a08797e

GH-611: add one more test and todos for Scanner

31f4356

GH-611: change Scanner from a trait to struct

9d3b3f0

GH-611: use RefCell to eliminate the problem with mutable closure ins…

d2e428b

…ide tools.rs

GH-611: remove redundant fields from tools.rs

b82293b

GH-611: migrate flag from Accountant to Scanner

f54ef5a

GH-611: fix test accountant_have_proper_defaulted_values

ba036ca

GH-611: rename items in tools.rs

cea6870

GH-611: add functions to update flag for is_scan_running

a97f6ac

GH-611: add a TODO for verifying that scanners are defaulted properly

0815a87

GH-611: throw error when scan is already running.

b3e34f5

GH-611: add a todo to handle the case when UI triggers a scan, but th…

fa30d82

…e scan is already running

GH-611: allow scan is running error logs to print the scan type

9f6639b

GH-611: write logs whenever a new scan is requested but scan is alrea…

0010876

…dy running

GH-611: rename the module to scanners

697ecd0

GH-611: use timestamp instead of boolean flag for marking whether a s…

dc85535

…can is running

GH-611: change the logs to include timestamp in case scan is already …

b79ad8b

…running

GH-611: add todos for ending scans for PendingPayables

30dc1ed

GH-611: use a RefCell to update the initiated_at variable

4109f9b

GH-611: add a test for testing whether scan has started

6a81fdf

GH-611: use mark_as_started() in the scan()

b4502c4

GH-611: end the scan for payables at handle_sent_payable()

52fac77

GH-611: allow blockchain bridge to send ReportTransactionReceipts wit…

4ba15cf

…h an empty vector

GH-611: disable starting and ending the scans to fix the tests in acc…

12aecc8

…ountant/mod.rs

GH-611: remove compiler warnings

b4753bb

GH-611: scanners struct can be constructed with the respective scanners

9497874

GH-611: eliminate the BeginMessageWrapper

4f7fbd2

GH-611: modify PayableDAOMock

57ca413

GH-611: modify PendingPayableDaoFactoryMock and ReceivableDaoFactoryMock

3e9651d

GH-611: supply DAOs for Scanner inside the tests of accountant/mod.rs

9fe65c7

utkarshg6 added 29 commits September 21, 2022 12:44

GH-611: remove the CancelFailedPendingTransaction message

54e71ed

GH-611: migrate tests for update_payable_fingerprint()

d25e290

GH-611: migrate tests for confirming pending transactions to scanners.rs

6325fcd

GH-611: remove transaction confirmation tools

9c342a1

GH-611: migrate handling of ReceivedPayments message to the scan_fini…

99d30dc

…shed() of scanners.rs

GH-611: use mark_as_started() to update the timestamp inside Scanners

86c4c22

GH-611: reanme ScannerError to BeginScanError

04bb7da

GH-611: replace Errors into panics inside scan_finished() of all the …

0f0eafc

…Scanners

GH-611: modify tests for Scanners to assert whether scan_finished() s…

249097a

…tops the scan

GH-611: add logging when scan has ended

ff347d3

GH-611: fix test for the periodical scanning of Payable Scanner

4faf4d4

GH-611: use ScannerMock for testing periodical scanning for payables

40bd90e

GH-611: fix test for the periodical scanning of receivables and deliq…

658c719

…uencies

GH-611: fix test for periodical scanning for pending payables

40f9ba3

GH-611: rename the fn name for stopping the system inside ScannerMock

bb2733c

GH-611: remove import warnings

3838826

GH-611: improve the implementation of ScannerMock

c23448e

GH-611: end the scan in case begin_scan() returns an error of nothing…

167b276

… to process

GH-611: refactor begin_scan() for Receivable Scanner

48a06af

GH-611: remove an obsolete assert realted to threshold tools

d5ffcea

GH-611: fix the test pending_transaction_is_registered_and_monitored_…

52bfd0c

…until_it_gets_confirmed_or_canceled()

GH-611: refactor scanners.rs

53a66e6

GH-611: use default implementation of PaymentThresholds

482b8ae

GH-611: migrate the test utility functions of scanner.rs to accountan…

1af6f2b

…t/test_utils.rs

GH-611: remove BannedDao and PaymentThresholds as a field of Accountant

6e3dd00

GH-611: implement scan_finished() for ScannerMock

6ab9c9b

GH-611: remove multiple occurences of BannedDao inside tests of accou…

b4389cf

…ntant/mod.rs

GH-611: rename scan_finished() to finish_scan()

8b73e99

Merge branch 'master' into GH-611

f3739b1

utkarshg6 commented Oct 3, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-611: Accountant Overlapping Scans (self review) #4

GH-611: Accountant Overlapping Scans (self review) #4

utkarshg6 commented Oct 3, 2022

utkarshg6 Oct 3, 2022

utkarshg6 Oct 3, 2022

utkarshg6 Oct 3, 2022

GH-611: Accountant Overlapping Scans (self review) #4

Are you sure you want to change the base?

GH-611: Accountant Overlapping Scans (self review) #4

Conversation

utkarshg6 commented Oct 3, 2022

utkarshg6 Oct 3, 2022

Choose a reason for hiding this comment

utkarshg6 Oct 3, 2022

Choose a reason for hiding this comment

utkarshg6 Oct 3, 2022

Choose a reason for hiding this comment