Skip to content

Conversation

robobenklein
Copy link
Member

@robobenklein robobenklein commented Mar 26, 2018

Tracking PR for finishing the Roboclaw appendage. (Not to be merged until spine can communicate all the way through to the drivetrain.)

Important Changes:

  • Includes Navigation/dev
  • Includes Appendages/roboclaw
  • Includes Robo/docker-go-script
  • Includes Arduino_gen/dev
  • Ultrasonic & Servo appendages
  • Fixes most of RIP CmdMessenger (in HACK-style)
  • Additional changes to integrate and fix other bugs that arise during testing.

Questions & TODO:

  • Roboclaw/dev: @solsane does this need to be integrated here at all? (Perhaps not?) @solsane opinions? After comp Todo
  • Navigation/localization: will need to be brought up to dev (might need to change how we're getting localization info because of this) @amessing your feedback requested
  • Periphery/dev: Do things in this PR need to be changed so that they make use of the new periphery features? Periphery OOP Interface #48 (Should this be included in the integration if so?) Who will check this?

Please review the changes here and begin submitting feedback now.

Right before merge checklist:

(In order to reduce chance of merge conflicts during the work...)

  • Fix indentation levels (currently mixed tabs and spaces)
  • Remove a lot of extra cout statements, convert some to RIP logger debugs.
  • Check in with roboclaw/dev and @solsane so they can get any important changes / potential problems from here onto that branch.
  • Perform complete production-mode test
    • Build hugo in production
    • Copy to robot
    • Build teensy appendage with arduino_gen and upload for orange
    • Run roboclaw diagnostic to ensure each motor controls correctly
    • New robot repo for competition bot??? ( whoever does see @robobenklein for specific cmake commands needed to separate build artifacts )

argvrutter and others added 30 commits February 20, 2018 17:33
Merge navigation/dev back into navx/dev for roboclaw fixes
'Docking' dev back into navigation/dev
@jptech jptech force-pushed the robo/integration-39 branch from c42f0dd to 156a412 Compare April 7, 2018 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants