Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/FPAY-1553 - create module dev #646

Merged
merged 1 commit into from
Oct 23, 2024
Merged

feature/FPAY-1553 - create module dev #646

merged 1 commit into from
Oct 23, 2024

Conversation

CharlesKP
Copy link
Contributor

No description provided.

@linear Linear
Copy link

linear bot commented Oct 23, 2024

FPAY-1553 Create MSK module for payment-deadletterd-service

@CharlesKP CharlesKP marked this pull request as ready for review October 23, 2024 08:47
@CharlesKP CharlesKP requested a review from a team as a code owner October 23, 2024 08:47
@uw-infra
Copy link

uw-infra commented Oct 23, 2024 •
edited
Loading

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-payment-platform
Path: dev-aws/kafka-shared-msk/payment-platform
Commit ID: 989a5f78238911e4f280ec1bf99ab9d5f747620e
✅ Run Status: Ok, Run Summary: Plan: 7 to add, 0 to change, 0 to destroy. 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.payment_deadletterd.kafka_acl.group_acl["payment-platform.payment-deadletterd"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.payment-deadletterd"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.payment_deadletterd.kafka_acl.producer_acl["payment-platform.openbanking-deadletter.v1.internal.payment-methods"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.openbanking-deadletter.v1.internal.payment-methods"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.payment_deadletterd.kafka_acl.producer_acl["payment-platform.openbanking-deadletter.v1.internal.payments"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.openbanking-deadletter.v1.internal.payments"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.payment_deadletterd.kafka_acl.producer_acl["payment-platform.payment-deadletter.v1.events"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.payment-deadletter.v1.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.payment_deadletterd.kafka_acl.topic_acl["payment-platform.openbanking-deadletter.v1.internal.payment-methods"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.openbanking-deadletter.v1.internal.payment-methods"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.payment_deadletterd.kafka_acl.topic_acl["payment-platform.openbanking-deadletter.v1.internal.payments"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.openbanking-deadletter.v1.internal.payments"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.payment_deadletterd.kafka_acl.topic_acl["payment-platform.payment-deadletter.v1.events"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.payment-deadletter.v1.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 7 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/payment-platform as comment.

@CharlesKP CharlesKP merged commit df828dc into main Oct 23, 2024
3 checks passed
@CharlesKP CharlesKP deleted the feature-FPAY-1553-create-deadletterd-module-dev branch October 23, 2024 09:57
@uw-infra
Copy link

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-payment-platform
Path: dev-aws/kafka-shared-msk/payment-platform
Commit ID: df828dc9966e1b80c1a16e26bb57bcf7fdbda05c
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 7 added, 0 changed, 0 destroyed 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.payment_deadletterd.kafka_acl.group_acl["payment-platform.payment-deadletterd"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.payment-deadletterd"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.payment_deadletterd.kafka_acl.producer_acl["payment-platform.openbanking-deadletter.v1.internal.payment-methods"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.openbanking-deadletter.v1.internal.payment-methods"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.payment_deadletterd.kafka_acl.producer_acl["payment-platform.openbanking-deadletter.v1.internal.payments"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.openbanking-deadletter.v1.internal.payments"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.payment_deadletterd.kafka_acl.producer_acl["payment-platform.payment-deadletter.v1.events"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.payment-deadletter.v1.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.payment_deadletterd.kafka_acl.topic_acl["payment-platform.openbanking-deadletter.v1.internal.payment-methods"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.openbanking-deadletter.v1.internal.payment-methods"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.payment_deadletterd.kafka_acl.topic_acl["payment-platform.openbanking-deadletter.v1.internal.payments"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.openbanking-deadletter.v1.internal.payments"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.payment_deadletterd.kafka_acl.topic_acl["payment-platform.payment-deadletter.v1.events"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=payment-platform/payment-deadletterd"
      + id                           = (known after apply)
      + resource_name                = "payment-platform.payment-deadletter.v1.events"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 7 to add, 0 to change, 0 to destroy.
module.payment_deadletterd.kafka_acl.group_acl["payment-platform.payment-deadletterd"]: Creating...
module.payment_deadletterd.kafka_acl.producer_acl["payment-platform.payment-deadletter.v1.events"]: Creating...
module.payment_deadletterd.kafka_acl.topic_acl["payment-platform.openbanking-deadletter.v1.internal.payments"]: Creating...
module.payment_deadletterd.kafka_acl.producer_acl["payment-platform.openbanking-deadletter.v1.internal.payments"]: Creating...
module.payment_deadletterd.kafka_acl.producer_acl["payment-platform.openbanking-deadletter.v1.internal.payment-methods"]: Creating...
module.payment_deadletterd.kafka_acl.topic_acl["payment-platform.payment-deadletter.v1.events"]: Creating...
module.payment_deadletterd.kafka_acl.topic_acl["payment-platform.openbanking-deadletter.v1.internal.payment-methods"]: Creating...
module.payment_deadletterd.kafka_acl.group_acl["payment-platform.payment-deadletterd"]: Creation complete after 1s [id=User:CN=payment-platform/payment-deadletterd|*|Read|Allow|Group|payment-platform.payment-deadletterd|Literal]
module.payment_deadletterd.kafka_acl.topic_acl["payment-platform.openbanking-deadletter.v1.internal.payment-methods"]: Creation complete after 1s [id=User:CN=payment-platform/payment-deadletterd|*|Read|Allow|Topic|payment-platform.openbanking-deadletter.v1.internal.payment-methods|Literal]
module.payment_deadletterd.kafka_acl.topic_acl["payment-platform.payment-deadletter.v1.events"]: Creation complete after 1s [id=User:CN=payment-platform/payment-deadletterd|*|Read|Allow|Topic|payment-platform.payment-deadletter.v1.events|Literal]
module.payment_deadletterd.kafka_acl.producer_acl["payment-platform.openbanking-deadletter.v1.internal.payments"]: Creation complete after 1s [id=User:CN=payment-platform/payment-deadletterd|*|Write|Allow|Topic|payment-platform.openbanking-deadletter.v1.internal.payments|Literal]
module.payment_deadletterd.kafka_acl.producer_acl["payment-platform.payment-deadletter.v1.events"]: Creation complete after 1s [id=User:CN=payment-platform/payment-deadletterd|*|Write|Allow|Topic|payment-platform.payment-deadletter.v1.events|Literal]
module.payment_deadletterd.kafka_acl.producer_acl["payment-platform.openbanking-deadletter.v1.internal.payment-methods"]: Creation complete after 1s [id=User:CN=payment-platform/payment-deadletterd|*|Write|Allow|Topic|payment-platform.openbanking-deadletter.v1.internal.payment-methods|Literal]
module.payment_deadletterd.kafka_acl.topic_acl["payment-platform.openbanking-deadletter.v1.internal.payments"]: Creation complete after 1s [id=User:CN=payment-platform/payment-deadletterd|*|Read|Allow|Topic|payment-platform.openbanking-deadletter.v1.internal.payments|Literal]

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 12, in provider "kafka":
  12: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `client_cert` instead.

(and one more similar warning elsewhere)

Apply complete! Resources: 7 added, 0 changed, 0 destroyed.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/payment-platform as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbuliarca sbuliarca sbuliarca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CharlesKP @uw-infra @sbuliarca