-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: inverted and outline button contrast #440
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 6741665 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🖥️ Native UI - Storybook PreviewVisit the Storybook preview URL to see the changes in action. 📱 Appetize PreviewsYou can view the apps using the link above and choosing the device from the top action bar. Alternatively you can use the direct links below. Last updated from commit 4ad85d9 |
|
||
_text: { | ||
color: `$${scheme}700`, | ||
color: `$${scheme}600`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question here: does this apply to ghost too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers, missed that one
}, | ||
|
||
_spinner: { | ||
_svg: { | ||
color: `$${scheme}50`, | ||
color: `$${scheme}100`, | ||
}, | ||
}, | ||
|
||
':active': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is :active
pressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes 🙂
}, | ||
}, | ||
|
||
':active': { | ||
backgroundColor: `$${scheme}900`, | ||
borderColor: `$${scheme}400`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is inverted only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The normal outline did need updating though, good spot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks so much
No description provided.