fix: inverted and outline button contrast #440
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 6741665 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🖥️ Native UI - Storybook PreviewVisit the Storybook preview URL to see the changes in action. 📱 Appetize PreviewsYou can view the apps using the link above and choosing the device from the top action bar. Alternatively you can use the direct links below. Last updated from commit 4ad85d9 |
|
|
||
| _text: { | ||
| color: `$${scheme}700`, | ||
| color: `$${scheme}600`, |
There was a problem hiding this comment.
question here: does this apply to ghost too?
There was a problem hiding this comment.
the disabled on inverted Button variant="ghost" was changed from 700 to 600 too (in all colorScheme)
There was a problem hiding this comment.
Cheers, missed that one
| }, | ||
|
|
||
| _spinner: { | ||
| _svg: { | ||
| color: `$${scheme}50`, | ||
| color: `$${scheme}100`, | ||
| }, | ||
| }, | ||
|
|
||
| ':active': { |
| }, | ||
| }, | ||
|
|
||
| ':active': { | ||
| backgroundColor: `$${scheme}900`, | ||
| borderColor: `$${scheme}400`, |
There was a problem hiding this comment.
not sure if this applies to inverted only,
on inverted false (light mode only) the border colour doesn't change on pressed (active) so in the case of cyan it stays at 400 and it the other colorScheme stays at 500
I see that maybe is only missing on cyan 🤔
There was a problem hiding this comment.
Yes this is inverted only
There was a problem hiding this comment.
The normal outline did need updating though, good spot
No description provided.