Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured BetaFlight controller into BetaAviary and CTBRControl. P… #170

Merged
merged 16 commits into from
Oct 13, 2023

Conversation

JacopoPan
Copy link
Member

…rovided beta2 example script.

known issue: slight variations exist between flight results of beta.py and beta2.py

…rovided beta2 example script.

known issue: slight variations exist between flight results of beta.py and beta2.py
@JacopoPan JacopoPan added the enhancement New feature or request label Aug 26, 2023
@JacopoPan JacopoPan marked this pull request as ready for review October 8, 2023 13:54
Copy link
Member Author

@JacopoPan JacopoPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will be adding UDP port changes and automation scripts to support multiple SITL in the upcoming commits

@JacopoPan
Copy link
Member Author

TODOs (CC @spencerteetaert)

  • modify BetaAviary to support multiple SITL betaflights on different UDP ports
  • automate the clone/edit/compile/config/launch of multiple SITL beta flights

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cp cp ~/gym-pybullet-drones/gym_pybullet_drones/assets/eeprom.bin ~/betaflight/
added by error? Assumes specific file structure in user's computer which is not generally true given the previous install instructions. Also has floating command in line 49, this is meant to be the object copied?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions clearer in beta.py. Approved, maybe remove the duplicate instructions and reference one from another

@JacopoPan
Copy link
Member Author

@spencerteetaert

multi BF example now working fine, only missing adding README/docstrings instructions on how to use assets/clone_bfs.sh

@JacopoPan JacopoPan merged commit c91605b into main Oct 13, 2023
1 check passed
@JacopoPan JacopoPan deleted the dev-sitl branch October 13, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants