Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split C2A communication functions prototype declaration header #630

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sksat
Copy link
Collaborator

@sksat sksat commented Mar 12, 2024

Related issues

N/A

Description

S2E has some C2A-interface for SILS-S2E; sometimes C2A's IfWrapper/HAL implementation calls S2E OBC_C2A functions like OBC_C2A_SendFromObc.
These functions are defned in src/components/real/cdh/on_board_computer_with_c2a.hpp.
However, it is unclear which functions are explicitly called by C2A.
So, this PR change these declaration into another header file.

Impact

minor update

Supplementary information

N/A

@sksat sksat added priority::medium priority medium C2A Something related with C2A flight software minor update add functionality in a backwards compatible manner labels Mar 12, 2024
@sksat sksat self-assigned this Mar 12, 2024
@sksat sksat requested a review from a team as a code owner March 12, 2024 15:42
@sksat sksat requested review from 200km, seki-hiro, suzuki-toshihir0, t-hosonuma and conjikidow and removed request for a team March 12, 2024 15:42
Copy link
Member

@200km 200km left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらも遅くなりましたが、Approveさせていただきました。
フォーマットチェックのみ引っかかっているようですので、修正をお願いします。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C2A Something related with C2A flight software minor update add functionality in a backwards compatible manner priority::medium priority medium
Projects
Status: 🏗 In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants