Add orbit observer #595
Merged
Add orbit observer #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
200km
added
priority::medium
200km
requested review from
suzuki-toshihir0,
t-hosonuma and
conjikidow
and removed request for
a team
200km
force-pushed
the
feature/add-position-observer
branch
from
c8fde09
to
b8019e5
Compare
sksat
reviewed
Mar 7, 2024
|
|
||
| // CompoBase | ||
| int prescaler = ini_file.ReadInt("COMPONENT_BASE", "prescaler"); | ||
| if (prescaler <= 1) prescaler = 1; |
There was a problem hiding this comment.
設定値をオーバーライドするのであれば warning を出した方がよいのではないでしょうか
There was a problem hiding this comment.
このコンポ以外も全て同様になっているので、別issueで切り出して一気に対応したいと思います。
There was a problem hiding this comment.
https://github.com/ut-issl/s2e-core/issues/624
でissueを作りました。
sksat
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
NA
Description
I added a basic position observing component.
Test results
Impact
NA
Supplementary information
NA