Split time manager cmd header #585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
これも CI 通ったな |
This was referenced May 18, 2023
|
色々マージされたので，rebase |
sksat
force-pushed
the
feature/split-time-manager-cmd-header
branch
from
80bb780
to
5251b7c
Compare
|
単なるヘッダ分割と思っていたけれど，C2A では1つのヘッダにコマンド定義含め色々定義して1つの.cで実装，というのが慣習になっているので，これをやるとすれば慣習自体に変更が要るとのこと．それ自体は方向性としてアリだし，これらの目的は #581 に留まらないので，別途 Issue を切る． |
|
rebase |
sksat
force-pushed
the
feature/split-time-manager-cmd-header
branch
from
5251b7c
to
0e5fff6
Compare
|
rebase |
sksat
force-pushed
the
feature/split-time-manager-cmd-header
branch
from
0e5fff6
to
81a0ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
ObcTimeの設定をobc_time.hから分割するIssue/PR
詳細
time_manager.hが C2A user に依存しなくなるtime_manager_cmd.hに分割される検証結果
CI が通ればよし
影響範囲
command_source.hでtime_manager.hではなくtime_manager_cmd.hを使うように変更する必要がある補足
何かあれば