Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anomaly Logger, Anomaly Handler の完全削除 #516

Merged
merged 11 commits into from
Mar 26, 2023

Conversation

meltingrabbit
Copy link
Collaborator

@meltingrabbit meltingrabbit commented Mar 12, 2023

概要

Anomaly Logger, Anomaly Handler の完全削除

Issue

詳細

ISSL でも ArkEdge Space でも使われてないことから,deprecated から正式に削除する

検証結果

  • すべての CI が通った

影響範囲

  • 全ての user で設定ファイルなどを削除する必要がある
  • これまで AH を使ってなかった user で set(USE_ALL_C2A_CORE_APPS OFF) を削除できる可能性がある
  • AL に依存している Util counter はコメントアウトした

@meltingrabbit meltingrabbit added documentation Improvements or additions to documentation enhancement New feature or request priority::high priorityg high labels Mar 12, 2023
@meltingrabbit meltingrabbit self-assigned this Mar 12, 2023
@meltingrabbit meltingrabbit changed the base branch from develop to feature/update_db_and_change_dr_partition_in_tsp March 12, 2023 18:20
@meltingrabbit
Copy link
Collaborator Author

@sksat cmake まわりで変なことしてないか見てほしい

@meltingrabbit
Copy link
Collaborator Author

これ,Release打つまでもないか?

@meltingrabbit meltingrabbit changed the title Pre Release (v3.8.0-beta.7): Anomaly Logger, Anomaly Handler の完全削除 Anomaly Logger, Anomaly Handler の完全削除 Mar 13, 2023
@sksat
Copy link
Collaborator

sksat commented Mar 13, 2023

beta 打つかはともかく,破壊的変更ではあるからリリース打っても損は無いと思う

Comment on lines +4 to +6
// FIXME
// error: ISO C requires a translation unit to contain at least one declaration [-Werror,-Wempty-translation-unit]
// 対策のために,適当に宣言しておく
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これはそもそもこのファイルが要らないわけではない?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは重要Appだけどメンテされてないので,残しておきたい(はよメンテせい,といわれればそう)

@sksat
Copy link
Collaborator

sksat commented Mar 13, 2023

@sksat cmake まわりで変なことしてないか見てほしい

これは OK

@meltingrabbit meltingrabbit force-pushed the feature/update_db_and_change_dr_partition_in_tsp branch from 2624ad4 to e84ac66 Compare March 16, 2023 14:01
Base automatically changed from feature/update_db_and_change_dr_partition_in_tsp to develop March 16, 2023 14:19
@meltingrabbit
Copy link
Collaborator Author

@chutaro approve頼む~~

Copy link
Contributor

@chutaro chutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません遅くなりました、approveしました!
少し細かい修正入れているので、それが良さそうであればマージしちゃってください

@meltingrabbit
Copy link
Collaborator Author

細かい修正めっちゃ助かる!!
確認します

@meltingrabbit meltingrabbit merged commit 34c24ce into develop Mar 26, 2023
@meltingrabbit meltingrabbit deleted the feature/remove_al_ah branch March 26, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request priority::high priorityg high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants