Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre Release (v3.8.0-beta.6): v3.8.0-beta.5 で追加された不適切なバリデーションの除去 #513

Closed
wants to merge 1 commit into from
Closed

Pre Release (v3.8.0-beta.6): v3.8.0-beta.5 で追加された不適切なバリデーションの除去 #513

wants to merge 1 commit into from

Conversation

meltingrabbit
Copy link
Collaborator

概要

Pre Release (v3.8.0-beta.6): v3.8.0-beta.5 で追加された不適切なバリデーションの除去

Issue

詳細

rx_buffer_size_in_if_rx_ が初期値だとDSの初期化に失敗してしまう

@meltingrabbit meltingrabbit added bug Something isn't working priority::high priorityg high labels Mar 10, 2023
@meltingrabbit meltingrabbit self-assigned this Mar 10, 2023
@meltingrabbit
Copy link
Collaborator Author

@hoshika-mas レビューお願いしたいです．
また，この branch でそちらの作業 C2A User の core update を試してほしいです

@hoshika-mas
Copy link
Contributor

@meltingrabbit

c2a-core/Drivers/Super/driver_super.h

Lines 18 to 19 in a4f4f01

* @note バッファのサイズ設定について
* - DS_StreamRecBuffer のサイズは rx_buffer_size_in_if_rx_ よりも大きい必要がある

この辺のコメントも見直した方が良い気がします。

@meltingrabbit
Copy link
Collaborator Author

meltingrabbit commented Mar 10, 2023 •
edited
Loading

あれ
rx_buffer_size_in_if_rx_ と max_rx_frame_size_ を勘違いしてたので，もうちょっと考えます．

@meltingrabbit
Copy link
Collaborator Author

いや，これはOKだった．

@meltingrabbit meltingrabbit deleted the hotfix/removing_inappropriate_validation branch March 12, 2023 17:29
@meltingrabbit meltingrabbit mentioned this pull request Mar 16, 2023
Merged
4 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chutaro chutaro Awaiting requested review from chutaro

@hoshika-mas hoshika-mas Awaiting requested review from hoshika-mas

Assignees

@meltingrabbit meltingrabbit

Labels
bug Something isn't working priority::high priorityg high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltingrabbit @hoshika-mas