init commit(feature/excel2toml) #335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Examples/minimum_user_for_s2e/src/src_user/TlmCmd/command_definitions.c
Outdated
Show resolved
Hide resolved
Examples/minimum_user_for_s2e/src/src_user/TlmCmd/command_definitions.c
Outdated
Show resolved
Hide resolved
Examples/minimum_user_for_s2e/src/src_user/TlmCmd/command_definitions.c
Outdated
Show resolved
Hide resolved
Examples/minimum_user_for_s2e/src/src_user/TlmCmd/command_definitions.c
Outdated
Show resolved
Hide resolved
Examples/minimum_user_for_s2e/src/src_user/TlmCmd/command_definitions.c
Outdated
Show resolved
Hide resolved
Examples/minimum_user_for_s2e/src/src_user/TlmCmd/command_definitions.c
Outdated
Show resolved
Hide resolved
Examples/minimum_user_for_s2e/src/src_user/TlmCmd/command_definitions.c
Outdated
Show resolved
Hide resolved
Examples/minimum_user_for_s2e/src/src_user/TlmCmd/command_definitions.c
Outdated
Show resolved
Hide resolved
|
フォルダ構造についてだけど、
|
chutaro
reviewed
May 27, 2022
Comment on lines
1116
to
1120
| # [[NonOrder]] | ||
| # name = "Cmd_OBC_CHECK_SIB_VERSION" | ||
| # params = 0 | ||
| # desc = "SIBとC2Aのバージョン整合性確認" | ||
| # code = "0x05ff" |
There was a problem hiding this comment.
@meltingrabbit
tlm-cmd-generatorだとここだけ出力されない設定になってますよね？このまま走らせるとcommand_diffinision.c にdiff 出ちゃうのでコメントアウトしてます。Cmd_OBC_CHECK_SIB_VERSION が必要ないのであればtoml移行に合わせて消しちゃってもいいですかね？
There was a problem hiding this comment.
toml移行に合わせて消しちゃってもいいですかね？
けさなないで，コメントアウトとして残しておいてほしい．
tomlでもコメントアウトしたいことでてくるはずなので．
There was a problem hiding this comment.
で，コメントアウトしたものは，ちゃんと .c/.h には反映されないようにしておいてほしい @flap1
There was a problem hiding this comment.
わかりました
現状コメントアウトしたものは反映しないようになってます
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
toml-based DBの適用
Issue
詳細
検証結果
h/cファイルのdiffはありません
(他OBCを含めたPacketID順にしたので少し変更ありますが)
影響範囲
補足
DBについてはtlm-cmd-dbのREADMEを見てください
注意