Conversation
Separate node layout (relative pin offsets) from geometry (absolute positions), replacing the single geometry calculator with a layout → geometry two-step. Switch node SVG wrapper from <g> to <svg> so child elements can use percentage dimensions. Update Display node to compute its size from config resolution and add a config settings button stub. Disable the ViewModeSwitcher play button when any input pin is unconnected. Remove redundant node/connection event listeners from the simulation trigger. Key changes covered: - Layout / LayoutSource types split out from Geometry, with nodePinOffsetById replacing absolute positions - <g> → <svg> in Node/index.tsx so Default can use width="100%" - Display/geometry.ts now scales with config.resolution and exports layout constants - New ConfigSettingButton component for Display nodes - isEachInputPinConnected utility in component.ts gating the play button - executeSimulation decoupled from raw store events in the core slice
Deploying create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee with
|
| Latest commit: |
1c94d8a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0a41459c.create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee.pages.dev |
| Branch Preview URL: | https://20260606.create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee.pages.dev |
- Make the display ConfigSettingButton functional: open a Popover form
to edit resolution (x/y) and persist via store.nodes.update
- Compute display node size from config inside the layout calculator
- Cache getNodePinBitWidthStatus results, invalidating on node/pin/
connection register/unregister/update events
- Switch input value bit-width init to getNodePinBitWidthStatus and
deprecate getComponentPinBitWidthStatus
- Convert InputValueKey from a tuple to a { componentPinId, timeStep }
object with a serializeInputValueKey helper
- Add a reactive useCanSimulate selector and use it to drive the
ViewModeSwitcher disabled state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate node layout (relative pin offsets) from geometry (absolute
positions), replacing the single geometry calculator with a
layout → geometry two-step. Switch node SVG wrapper from to
so child elements can use percentage dimensions. Update Display node
to compute its size from config resolution and add a config settings
button stub. Disable the ViewModeSwitcher play button when any input
pin is unconnected. Remove redundant node/connection event listeners
from the simulation trigger.
Key changes covered: