10525: Full Spectrum Docket Sorting #5585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, and by default;
… throught to the PDF generation method;
… currently selected option key;
Mwindo
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Thanks @cruzjone-flexion and @nechama-krigsman! This looks good overall.
I did see a discrepancy with the sorted order in the UI vs. the printable record when sorting by pages locally (I let the former of you know), and I think I need to understand the purpose of KEYS and ROOT a little better before giving my full thumbs up.
cypress/helpers/caseDetail/docketRecord/paperFiling/fill-paper-filing-form.ts
Show resolved
Hide resolved
cypress/local-only/tests/integration/caseDetail/docketRecord/docketRecordSort.cy.ts
Outdated
Show resolved
Hide resolved
…ternal docket record table;
Mwindo
approved these changes
Nov 25, 2024
nechama-krigsman
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.