Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10554: Fix disappearing messages bug #5575

Draft
wants to merge 3 commits into
base: staging
Choose a base branch
from
Draft

10554: Fix disappearing messages bug #5575

wants to merge 3 commits into from

Conversation

En-8
Copy link
Contributor

@En-8 En-8 commented Nov 20, 2024

flexion#10554

  • Properly set the parentMessageId when navigating to the "Apply Stamp" page so that the Stamp Order document is either associated with the correct message or no message (if stamped from document view)
  • Don't mark message threads as "replied to" until after the new message has been validated, so that if there are any errors during the validation we don't mark the thread (this was what caused messages to disappear if they were impacted by the above stamping issue)
  • Wrap "mark thread replied to" and "create message" writes in a single transaction, so that if writing the new message fails for whatever reason, the thread is not marked as "replied to"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@En-8