Dexex organize docket sorting (WIP) #5556
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rialSessionDetails, which does not say what it sorts by and is imported in places that seem unrelated to getting formatted trial session details, with a more intuitive sorting function that does the same thing
Mwindo
changed the title
… adding and modifying tests
… from Case.ts and beginning to deal with the consequences of refactoring
Mwindo
commented
Nov 18, 2024
Comment on lines
-474
to
-478
| if (isReversed) { | ||
| // reversing AFTER the sort keeps sorting stable | ||
| return docketEntries.reverse().sort(sortUndefined); | ||
| } | ||
| return docketEntries.sort(sortUndefined); |
There was a problem hiding this comment.
We were sorting the whole list twice rather than improving our a custom comparison function to allow us to sort once.
Mwindo
commented
Nov 18, 2024
| @@ -0,0 +1,76 @@ | |||
| const getSortableDocketNumber = (docketNumber?: string) => { | |||
There was a problem hiding this comment.
This file is just logic moved over from Case.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. Please ignore for now.
We have several different methods for sorting docket-related things scattered throughout the codebase. This PR attempts to collect them in one place, refactoring and renaming them for clarity as need be.