Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10293 design debt #5541

Draft
wants to merge 45 commits into
base: staging
Choose a base branch
from
Draft

10293 design debt #5541

wants to merge 45 commits into from

Conversation

akuny
Copy link
Contributor

@akuny akuny commented Nov 13, 2024

See 10293.

This PR integrates the client-side paginator into the following reports:

  • Case Inventory
  • Deadlines
  • Pending Report

Summary of Changes

  1. Client-Side Paginator Refactoring:

    • Extracted the useClientSidePaginator hook from ColdCaseReportList.tsx to allow for consistent client-side pagination across different reports.
    • Since pagination state is exclusively relevant to the React components displaying these reports, I could not think of a compelling reason to manage this state within individual slices of the Cerebral state tree.
  2. Removal of Server-Side Pagination Logic:

    • The following persistence functions no longer include server-side pagination logic:
      • getCaseInventoryReport
      • fetchPendingItems
      • getCaseDeadlinesByDateRange
    • Corresponding interactors and proxies have been updated to reflect this change.
  3. Removal of Obsolete Cerebral Functionality:

    • The following sequences and actions have been removed, and associated Cerebral integration tests have been updated accordingly:
      • caseInventoryReportLoadMoreSequence
      • loadMoreCaseDeadlinesSequence
      • loadMorePendingItemsSequence
      • incrementPendingItemsPageAction
      • incrementScreenMetadataPageAction

@akuny akuny added the to test label Nov 13, 2024
@akuny akuny changed the base branch from test to staging November 20, 2024 16:25
@akuny akuny added to staging and removed to test labels Nov 20, 2024
akuny added 19 commits November 25, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant