Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10275 calendar generator #5502

Draft
wants to merge 225 commits into
base: staging
Choose a base branch
from

Conversation

akuny
Copy link
Contributor

@akuny akuny commented Oct 31, 2024

No description provided.

En-8 and others added 30 commits September 4, 2024 16:41
…ntialTrialLocations outside of reducer callback
En-8 and others added 29 commits November 6, 2024 13:25
…modal; update warning messages; update cell colors and widths
howMuch: 1,
units: 'days',
})}
parentModalHasMounted={isModalMounted}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than pass in another parameter to DateRangePickerComponent, can we just do

          {isModalMounted && ( // Otherwise the date picker doesn't load properly
            <DateRangePickerComponent
              endDateErrorText={validationErrors.termEndDate}
              endLabel="Term end date"
              endName="termEndDate"
              endPickerCls={'grid-col-6'}
              endValue={modal.termEndDate}
              formGroupCls="margin-bottom-0"
              minDate={calculateISODate({
                dateString: todaysDate,
                howMuch: 1,
                units: 'days',
              })}
              rangePickerCls={'grid-row grid-gap'}
              startDateErrorText={validationErrors.termStartDate}
              startLabel="Term start date"
              startName="termStartDate"
              startPickerCls={'grid-col-6'}
              startValue={modal.termStartDate}
              onChangeEnd={e => {
                updateModalValueSequence({
                  key: 'termEndDate',
                  value: e.target.value,
                });
              }}
              onChangeStart={e => {
                updateModalValueSequence({
                  key: 'termStartDate',
                  value: e.target.value,
                });
              }}
            />
          )}

My suspicion is that there is something weird about how we handle modals that this is necessary at all, but I suppose that's outside the scope of this ticket!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants