-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10275 calendar generator #5502
Draft
akuny
wants to merge
225
commits into
ustaxcourt:staging
Choose a base branch
from
flexion:10275-calendar-generator
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
10275 calendar generator #5502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ES and SESSION_TYPES constants
…ents, clean up logs
…ng, date assignment.
…ntialTrialLocations outside of reducer callback
…ession in the past two terms
…the past two terms
…into 10275-calendar-generator
…handling offset dates
…modal; update warning messages; update cell colors and widths
…0275-calendar-generator
Mwindo
reviewed
Nov 21, 2024
howMuch: 1, | ||
units: 'days', | ||
})} | ||
parentModalHasMounted={isModalMounted} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than pass in another parameter to DateRangePickerComponent
, can we just do
{isModalMounted && ( // Otherwise the date picker doesn't load properly
<DateRangePickerComponent
endDateErrorText={validationErrors.termEndDate}
endLabel="Term end date"
endName="termEndDate"
endPickerCls={'grid-col-6'}
endValue={modal.termEndDate}
formGroupCls="margin-bottom-0"
minDate={calculateISODate({
dateString: todaysDate,
howMuch: 1,
units: 'days',
})}
rangePickerCls={'grid-row grid-gap'}
startDateErrorText={validationErrors.termStartDate}
startLabel="Term start date"
startName="termStartDate"
startPickerCls={'grid-col-6'}
startValue={modal.termStartDate}
onChangeEnd={e => {
updateModalValueSequence({
key: 'termEndDate',
value: e.target.value,
});
}}
onChangeStart={e => {
updateModalValueSequence({
key: 'termStartDate',
value: e.target.value,
});
}}
/>
)}
My suspicion is that there is something weird about how we handle modals that this is necessary at all, but I suppose that's outside the scope of this ticket!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.