using pqueue instead of chunk+Promise.all() for setTrialSessionCalendarInteractor #5223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the course of updating acquireLock#removeLock to use dynamodbClientService#batchDelete(), I also went ahead and added typing for the for the batchDelete method. There was another type warning in dynamodbClientService that was not introduced by me, but needed to be addressed in order to commit, so i resorted to changing an untyped variable to type any[]. Apologies.
akuny
approved these changes
Sep 9, 2024
| @@ -144,10 +145,8 @@ export const setTrialSessionCalendarInteractor = async ( | |||
| // Story: 10422 | |||
There was a problem hiding this comment.
If this comment proved useful, it may be worth updating it to include some information about why we're using the p-queue module here as opposed to the previous approach.
jimlerza
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.