Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10007 story #4447

Merged
merged 887 commits into from
Mar 12, 2024
Merged

10007 story #4447

merged 887 commits into from
Mar 12, 2024

Conversation

pixiwyn
Copy link
Contributor

@pixiwyn pixiwyn commented Dec 20, 2023

Deployment Steps

  • Run an environment specific deploy:
    • Use the environment switcher to point to the deploying environment.
    • Run npm run deploy:environment-specific <ENV>
  • Run an account specific deploy:
    • Use the environment switcher to point to the deploying environment.
    • Run npm run deploy:account-specific
  • Kick off Circle build. (NOTE: First build will FAIL)
    • Copy worker_<DEPLOYING_COLOR>.js.zip and upload a copy as worker_<CURRENT_COLOR>.js.zip to the S3 lambda bucket ${var.dns_domain}.efcms.${var.environment}.us-west-1.lambdas and ${var.dns_domain}.efcms.${var.environment}.us-east-1.lambdas
  • Restart Circle build.
  • After deployment has finished, subscribe to the new sns topic system_health_alarms in us-west-1.

Rollback Steps (Run these steps in the unlikely event you want to revert the deploy of this story.)

  • Switch back to the branch/commit hash that you would like to revert to.
  • Run an environment specific deploy:
    • Use the environment switcher to point to the deploying environment.
    • Run npm run deploy:environment-specific <ENV>
  • Run an account specific deploy:
    • Use the environment switcher to point to the deploying environment.
    • Run npm run deploy:account-specific
  • Kick off Circle build.
  • Disengage Maintenance Mode:
    • Use the environment switcher to point to the deploying environment.
    • Run npm run maintenance:disengage <ENV>

Zachary Rogers and others added 25 commits February 12, 2024 14:58
…, set local storage item to indicate opening create order in same tab for cypress test after logging in
initiateAuthResult.ChallengeName !==
ChallengeNameType.NEW_PASSWORD_REQUIRED
) {
throw new Error('User is not in `FORCE_CHANGE_PASSWORD` state');
Copy link
Collaborator

@mmarcotte mmarcotte Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking about this implementation and pattern. Thinking about option enabling architecture could/should the persistence/auth layer handle these exceptions and throw non-Cognito like error messages?

For example,

if (tempPassword) { 
  const { AccessToken, IdToken, RefreshToken } = await applicationContext.getUserGateway().confirmTempUser(email, tempPassword);
  // the above would throw the relavent errors

  // queue work if they're a pendingEmail
} else {
  const { AccessToken, IdToken, RefreshToken } = await applicationContext.getUserGateway().confirmForgotPassword(code, email, password);
  // the above would throw the relavent errors

}

What you have is totally okay for now, but trying to think about potential next steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good observation, we are tackling some of this as a part of DoD here: flexion#10278

Copy link
Collaborator

@mmarcotte mmarcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whooooah, this is excellent work. thank you for all the hard work.

excellent

@jimlerza jimlerza merged commit 0751c48 into ustaxcourt:staging Mar 12, 2024
37 checks passed
@jimlerza jimlerza mentioned this pull request Mar 15, 2024
8 tasks
@rachelschneiderman rachelschneiderman deleted the 10007-story branch March 28, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants