-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10007 story #4447
10007 story #4447
Conversation
166d1a3
to
ab0eef3
Compare
…, set local storage item to indicate opening create order in same tab for cypress test after logging in
…ustom cognito UI anymore
… workflows for deployments.
…enance mode is on
initiateAuthResult.ChallengeName !== | ||
ChallengeNameType.NEW_PASSWORD_REQUIRED | ||
) { | ||
throw new Error('User is not in `FORCE_CHANGE_PASSWORD` state'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking about this implementation and pattern. Thinking about option enabling architecture could/should the persistence/auth layer handle these exceptions and throw non-Cognito like error messages?
For example,
if (tempPassword) {
const { AccessToken, IdToken, RefreshToken } = await applicationContext.getUserGateway().confirmTempUser(email, tempPassword);
// the above would throw the relavent errors
// queue work if they're a pendingEmail
} else {
const { AccessToken, IdToken, RefreshToken } = await applicationContext.getUserGateway().confirmForgotPassword(code, email, password);
// the above would throw the relavent errors
}
What you have is totally okay for now, but trying to think about potential next steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good observation, we are tackling some of this as a part of DoD here: flexion#10278
web-api/src/persistence/dynamo/users/getAccountConfirmationCode.ts
Outdated
Show resolved
Hide resolved
web-api/src/persistence/dynamo/users/createOrUpdatePractitionerUser.ts
Outdated
Show resolved
Hide resolved
web-api/src/business/useCases/user/verifyUserPendingEmailInteractor.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…amoDB may not delete expired TTL records for days after they have expired
f944c4c
to
b059914
Compare
Deployment Steps
npm run deploy:environment-specific <ENV>
npm run deploy:account-specific
${var.dns_domain}.efcms.${var.environment}.us-west-1.lambdas
and${var.dns_domain}.efcms.${var.environment}.us-east-1.lambdas
system_health_alarms
in us-west-1.Rollback Steps (Run these steps in the unlikely event you want to revert the deploy of this story.)
npm run deploy:environment-specific <ENV>
npm run deploy:account-specific
npm run maintenance:disengage <ENV>