-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PFHub CLI tool #1510
Draft
wd15
wants to merge
71
commits into
usnistgov:master
Choose a base branch
from
wd15:upload-notebook
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PFHub CLI tool #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zip and unzip are required for zipping files in the upload form.
upload.md is now a notebook in results/ as that directory is the correct environment.
Implement the conversion of meta.yaml records to a Zenodo record.
Necessary templages for the meta -> zenodo translation
This removes the htmlproofer checks. This isn't currently available in Nixpkgs and doesn't play well with the jekyll ruby environment in the latest Nix.
Updated pykwalify so needed to change the schema slightly.
Testing distributing a command line too for pfhub. - Add versioneer to deal with version numbers
zenodo_client will be used to upload to zenodo in the CLI. Also added twine and versioneer to upload to PyPI and genearte version numbers, respectively.
Update setup.cfg to include all the dependencies to make python-pfhub work in a Pip/Conda environment. Also, update setup.cfg for CLI script and versioneer.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Cool!!! |
Nix develop was broken in the base directory due to dotwiz after recent changes. Dotwiz now installed with Nix. - Use separate nix file for python packages - revert to dotwiz 0.2.0 as easier to install with nix
CLI tool will check valid files so needs a valid schema present
Run the CLI tool outside of the working copy to ensure that required files are installed.
CLI now has a validate command to validate YAML files against the schemas. In addition - reorder some of the code - using linkml CLI tool from Python - make file path checking better with Click arguments - make the command names more sensible - sys.exit(1) when invalid files
linkml needs to added to nixpkgs along with other libraries
Using _data/python-pfhub/.loca for local python installs.
Reverse order of flake check so that _data/python_pfhub/flake.nix is first. Checking to see if linkml will work.
Nix build is broken due to unforseen issues with linkml
Greenlet is pinned for linkml which requires it to be pinned. If not pinned then something else is installing a version to new for linkml.
Download command of the CLI gets records from PFHub only including linking back to Zenodo. The old download command is not download_zenodo, which makes more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CLI to download, submit and convert PFHub results
Some of these commits are in #1508
Todo:
convert-to-zenodo
convert-to-meta
Ideas:
pfhub upload {zenodo-record} --sandbox ???
sandbox=true
to submit to Zenodo sandbox~.pfhubrc
file locally to set parameters for zenodo and pfhub submissionpfhub submit --path=./ --config_path=~/pfhubrc --sandbox=true
pfhub convert
pfhub check
pfhub generate_notebook
?pfhub generate_yaml
?Done:
pfhub
CLIdownload
command for both meta.yaml and Zenodo links