Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add snapshot_created_on field to resource response schemas #699

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

keithmanville
Copy link
Collaborator

This commit adds the snapshot_created_on datetime field to all Resource response schemas. It also updates the build_ helper functions to include the field in responses and updates the test suite to validate the updated response schemas.

@keithmanville keithmanville force-pushed the add-snapshot-create-on branch 2 times, most recently from 7b1f462 to 9437782 Compare December 23, 2024 19:43
@keithmanville keithmanville linked an issue Dec 23, 2024 that may be closed by this pull request
4 tasks
@keithmanville keithmanville marked this pull request as ready for review December 23, 2024 19:45
Copy link
Collaborator

@henrychoy henrychoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Snapshots now have snapshotCreatedOn which is timestamp when it was created.

This commit adds the snapshot_created_on datetime field to all Resource response schemas. It also
updates the `build_` helper functions to include the field in responses and updates the test suite
to validate the updated response schemas.
@keithmanville keithmanville merged commit 26f2095 into dev Dec 24, 2024
11 checks passed
@keithmanville keithmanville deleted the add-snapshot-create-on branch December 24, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add snapshotCreatedOn to Resource response types in REST API
2 participants