-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: access control and user management with Keycloak #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix for windows * disable CORS for development purposes * add dependencies and quick test configuration * new security config. linked back-end and keycloak * WIP commit for fix * add security on CsvCollection * update security on ImagesCollection. Add security for Image and MetadataFile * add security on Pyramid and PyramidTimeSlice * add security on StitchingVector and StitchingVectorTimeSlice * add security on TensorboardLogs * add security on TensorflowModel * add security on Visualization * update helper classes for security * add security on Job * add security on Workflow * add helper classes for Security Core * add security on Argo workflows * update Keycloak configuration * code cleanup & add dependency * fix dependencies for merge * restore workflow converter for merge * windev not active by default * remove useless annotation * add boolean editMode * final cleanuo
…eredRepository
Samiasa
reviewed
Jul 21, 2020
csvCollectionRepository.save(csvCollection); | ||
@Override | ||
public void importData(Job job, String outputName) throws JobExecutionException { | ||
CsvCollection csvCollection = new CsvCollection(job, outputName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
Samiasa
reviewed
Jul 21, 2020
csvCollection.setOwner(job.getOwner()); | ||
// Set collection to private | ||
csvCollection.setPubliclyShared(false); | ||
csvCollectionRepository.save(csvCollection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
…erform repository queries
…nnotations endpoints
…xt-argo feat: add pod security context argo
MyleneSimon
changed the title
[WIP] feat: access control and user management with Keycloak
feat: access control and user management with Keycloak
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduction of users in WIPP, access control and integration with Keycloak
Roadmap:
Special considerations:
WorkflowExitController
is not secured for now to allow for Argo to post workflow status without bearer token. Two solutions considered for next iteration:WDZT is not handling auth tokens for nowFixed in [email protected]