USH 1204 - Errors in console after CSV Import #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angamanga
requested changes
Mar 20, 2024
| @@ -25,6 +25,7 @@ export class ImportResultsComponent implements OnInit { | |||
|
|
|||
| ngOnInit(): void { | |||
| const jobId = this.route.snapshot.queryParamMap.get('job')?.split(','); | |||
| console.log(jobId); | |||
| if (jobId) { | |||
There was a problem hiding this comment.
Remove the console.log 🙃
| result.forEach((job: any) => { | ||
| if (job.result.status === 'SUCCESS') { | ||
| this.showNotification('success'); | ||
| this.importFinished.next(job.result); |
There was a problem hiding this comment.
It works, but the text in the notification says "Upload complete. You should now see your tagged data in your HDX account.", I think it is the title that is hardcoded on row 95. Maybe we need to send that from the start instead in order to be able to reuse the function?
tuxpiper
pushed a commit
that referenced
this pull request
May 10, 2024
* First cut, basic functionality fixed. Probably should clean it up though * Removed the snackbar stuff and added an error result page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues following a CSV import, specifically allowing the user to be notified that the job was successful or not. Previously this functionality was incomplete, meaning the status page would endlessly loop, the user would never be notified of the job's success or failure and the console would fill up with errors.
https://linear.app/ushahidi/issue/USH-1204/messy-console-with-error-code-500-when-attempting-import