-
Notifications
You must be signed in to change notification settings - Fork 81
xml attribute locations #1893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
xml attribute locations #1893
Conversation
jurgenvinju
commented
Nov 27, 2023
- Using jsoup 1.17.1 which can track attribute locations
- minor refactoring for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge this after you've got the build to succeed.
would be nice if we could add some tests? but otherwise: all good.
Thanks!
|
See jhy/jsoup#1933 |
@jurgenvinju the features in the PR are not part of main yet, right? These would be required in order for me to publish the XML M3. |
I checked the version in this branch. It would be super helpful to also have a |