Skip to content

Conversation

jurgenvinju
Copy link
Member

  • Using jsoup 1.17.1 which can track attribute locations
  • minor refactoring for clarity

Copy link
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge this after you've got the build to succeed.

would be nice if we could add some tests? but otherwise: all good.

@jurgenvinju
Copy link
Member Author

jurgenvinju commented Nov 28, 2023

Thanks!

  • Found a bug in the jsoup implementation, so I'm waiting for that fix and a release.
  • If we ever want to lift these node to parse trees we also need the locations of the names of the attributes. So I'm thinking to extend the srcs map to map[str label, tuple[loc name, loc val] src]

@jurgenvinju
Copy link
Member Author

See jhy/jsoup#1933

@linuswagner
Copy link

linuswagner commented Sep 20, 2025

@jurgenvinju the features in the PR are not part of main yet, right? These would be required in order for me to publish the XML M3.

@linuswagner
Copy link

linuswagner commented Sep 20, 2025

I checked the version in this branch. It would be super helpful to also have a src for the name of the tag (at the moment Node.src return the entire tag) and for "value" of the tag (<tag>VALUE</tag>)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants