Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize filters sync #4260

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Optimize filters sync #4260

merged 2 commits into from
Jan 4, 2025

Conversation

chriscurrycc
Copy link
Contributor

  • Resolve tag redirection issue as per Fix tag redirection in memos detail page #4232.
  • Implement bi-directional filters synchronization between filterStore and query parameters.
  • Fix issue where the location was updated unexpectedly due to incorrect triggering of setSearchParams.

@chriscurrycc chriscurrycc requested a review from boojack as a code owner January 2, 2025 16:12
johnnyjoygh
johnnyjoygh approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@johnnyjoygh johnnyjoygh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome!

web/src/components/MemoContent/Tag.tsx Show resolved Hide resolved
@johnnyjoygh johnnyjoygh merged commit d81174a into usememos:main Jan 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyjoygh johnnyjoygh johnnyjoygh approved these changes

@boojack boojack Awaiting requested review from boojack boojack is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriscurrycc @johnnyjoygh