Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share tags #4198

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Share tags #4198

wants to merge 8 commits into from

Conversation

RoccoSmit
Copy link
Contributor

@RoccoSmit RoccoSmit commented Dec 15, 2024

As per #3103, #3985 and #4178 users are currently not able to share tag across workspaces.

This PR is to allow for workspace and public tags to be shared.

Design decision:

  • I tried to keep with the current design of using the ListMemos endpoint and setting the data that is needed via the request.View flag similar to what is done with memos vs metadata. I could not piggyback off the metadata flow as the metadata numbers would include other user's memos as well
  • I started going down the path of creating a generic filter structure and consumer that would allow for building filters that have multiple checks, but it got very involved so I went for the simpler adding of the ShareTags property on the filter object and adding extra SQL to go along with it.
  • Users can rename and edit other user's tags. This will only take effect on memos that are marked as workspace or public
  • I didnt want the PR to get too big so I did not add other languages for the share tags setting. I can do that separately if the PR gets approved.

Experience:

in the below examples there are 2 users (User-1 and User-2). They both have 1 private, workspace and public memo with an identifying tag name in each. each user also has a workspace level link, todo and code memo.

Settings screen
image

Shared tags showing in the tag panel and metadata numbers are for user only
image

User only has access to their own private tags
image

User has access to shared tags
image

The explore page still functions as expected logged in and out
logged in
image

logged out
image

Tested in:

  • Firefox ✔️
  • Chromium ✔️
  • SQLite ✔️
  • Mysql ✔️
  • Postgres ✔️

@RoccoSmit RoccoSmit requested a review from boojack as a code owner December 15, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant