Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Extends the error alert for variables #187

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Nov 2, 2023

Extends the error alert for the variables tabs to cover add, view and delete.

The only caveat is that when there are no current variables, a user has to go through the motions to create one to discover that they can't - this is owing to a state issue in which the UI has no idea of the variables until they are viewed.

We are looking at ways to resolve this, but in the meantime, we can streamline all the error messages.

@CGoodwin90 CGoodwin90 marked this pull request as ready for review November 3, 2023 00:45
@tobybellwood
Copy link
Member

This works better!

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve this, given the state caveat. Works well now, and provides a consistent experience.

@tobybellwood tobybellwood merged commit 43ee5b5 into main Dec 4, 2023
2 checks passed
@tobybellwood tobybellwood deleted the updates_error_alert branch December 4, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants