Skip to content

Conversation

@olivermrose
Copy link
Collaborator

redo of #169

Copilot AI review requested due to automatic review settings December 19, 2025 07:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the 7TV event subscription system by adding channel identification to subscription keys, preventing conflicts when managing subscriptions for multiple channels. The implementation follows the same pattern already established by the EventSub client.

Key changes:

  • Updated all 7TV subscription methods to include a channel parameter
  • Changed subscription key format from event to channel:event
  • Modified unsubscribe_all to filter subscriptions by channel prefix

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/lib/handlers/seventv/user-update.ts Updated resub_emote_set invocation to include the channel username parameter
src-tauri/src/seventv/mod.rs Added channel parameter to resub_emote_set command and updated subscribe/unsubscribe calls
src-tauri/src/seventv/client.rs Refactored subscription methods to accept channel parameter and use channel:event keys; improved unsubscribe_all to filter by channel prefix
src-tauri/src/api.rs Updated all 7TV subscription calls in join/leave functions to include channel parameter

After thoroughly reviewing this pull request, I found no issues with the implementation. The changes are consistent, well-structured, and follow existing patterns in the codebase. All subscription-related calls have been properly updated to include the channel parameter, and the new scoping mechanism should prevent subscription conflicts across multiple channels.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@olivermrose olivermrose merged commit 8d4fd63 into main Dec 19, 2025
8 checks passed
@olivermrose olivermrose deleted the fix/sub-key branch December 19, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants