Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/control UI font size #772

Closed

Conversation

leabuende
Copy link

Description

This PR addresses the issue #713 and allows setting font-size on all Code Editor components from the Preferences>Font form. I have implemented it similarly to how the setting of the font family is already done.

Capture d’écran 2023-10-24 à 21 04 42

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@leabuende
Copy link
Author

Hey @helloanoop ! The end of Hacktoberfest is approaching, is there something I can do to improve my PR ? 😄

Copy link
Member

@Its-treason Its-treason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leabuende, sorry for the long wait. Your PR looks.

Due to the time this has been open, there is small a merge conflict in /src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/CodeView/index.js

And there are some new places where size needs to be passed into the code editor component:

  • packages/bruno-app/src/components/CollectionSettings/Docs/index.js
  • packages/bruno-app/src/components/CollectionSettings/Script/index.js
  • packages/bruno-app/src/components/CollectionSettings/Tests/index.js
  • packages/bruno-app/src/components/Documentation/index.js

I would appreciate it if you solve the merge conflicts and add the size props to the new editor. If you don't have the time to do it, just let me know and can make these changes.

@helloanoop
Copy link
Contributor

Thanks for all the time and effort @leabuende !
This functionality has been merged as a part of #2204

@helloanoop helloanoop closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants