Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bulk edit mode for request headers #706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chriscasola
Copy link

@chriscasola chriscasola commented Oct 20, 2023

Description

This PR adds a bulk edit mode for request headers.

image image

Currently this is only available on the headers tab for requests. The headers entry for collections uses a completely different component for some reason. I can make a follow up change that consolidates to a shared header editing component and uses it in both places.

Closes #185

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

@helloanoop helloanoop added this to the v2 milestone Oct 22, 2023
@chriscasola
Copy link
Author

@helloanoop would you consider merging this? It would make use of Bruno much easier for people at our company, where we frequently need to copy/paste a list of HTTP headers into the request.

@rzvxa
Copy link

rzvxa commented Nov 16, 2023

Hello, This feature is amazing and I really miss it after migrating from the postman.
My only issue with this PR is with stopping at headers and leaving out other sections for example query params.
We should generalize this implementation so we can leverage the bulk editor in every key-value editor in Bruno.
I would happily pitch in some time toward implementing this feature, Just let me know if you want me to work on this PR with you.

Have a great day,
Keep up the good work.

@rzvxa
Copy link

rzvxa commented Nov 16, 2023

I also hope we can merge it before version 2, I'm not sure when is the deadline for V2 but this feature is a must and I don't believe it is that big of change. Why delay merging it till the next major release? @helloanoop

@chriscasola
Copy link
Author

It would be awesome to get this merged. Can you help with that @flaviopangracio ?

@Bervenia
Copy link

@chriscasola / @rzvxa Out of curiosity, what's the next steps after @flaviopangracio approved the changes?

@rzvxa
Copy link

rzvxa commented Jul 23, 2024

@Bervenia I don't know, To be frank, I've lost interest in the project. I stick to the curl and swagger these days.

@sanjai0py
Copy link
Member

Hello everyone following this PR. We apologize for the delay in merging this PR. The Bruno team has been working on improving the security functionalities of Bruno. We will get this PR merged soon!

Also, apologize to @rzvxa for the inconvenience caused. If you have time, please provide us with your feedback on how we could improve. Your input is highly valued and appreciated!

@BenSnellgrove
Copy link

I've suggested a header clone button as an interim solution. Its messy and doesn't do everything a bulk edit mode would do, but since this PR is over a year old my hope is it will at least bring attention to this lack of functionality

@thodzai
Copy link

thodzai commented Jan 10, 2025

Would be nice to have it in Vars Tab and Collection Environments also.
Will it coming in version 1.38.2 @chriscasola ?
Thanks for your hard work.

@meostyles
Copy link

meostyles commented Feb 11, 2025

FWIW the lack of this feature makes it difficult to migrate from Postman to Bruno. So delaying merging of the PR by a year and a half seems like a mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bulk edit mode for request parameters, headers, vars, etc.
9 participants